2021-12-08 15:42:22

by Alexander Lobakin

Subject: Re: [net v5 0/3] fix bpf_redirect to ifb netdev

From: Tonghao Zhang <[email protected]>
Date: Wed, 8 Dec 2021 22:54:56 +0800

> From: Tonghao Zhang <[email protected]>
>
> This patchset try to fix bpf_redirect to ifb netdev.
> Prevent packets loopback and perfromance drop, add check
> in sch egress.

Please provide a changelog in the cover letter. With the links to
your previous versions ideally.
Otherwise it becomes difficult to understand what are the changes
between them.

>
> Tonghao Zhang (3):
> net: core: set skb useful vars in __bpf_tx_skb
> net: sched: add check tc_skip_classify in sch egress
> selftests: bpf: add bpf_redirect to ifb
>
> net/core/dev.c | 3 +
> net/core/filter.c | 12 ++-
> tools/testing/selftests/bpf/Makefile | 1 +
> .../bpf/progs/test_bpf_redirect_ifb.c | 13 ++++
> .../selftests/bpf/test_bpf_redirect_ifb.sh | 73 +++++++++++++++++++
> 5 files changed, 101 insertions(+), 1 deletion(-)
> create mode 100644 tools/testing/selftests/bpf/progs/test_bpf_redirect_ifb.c
> create mode 100755 tools/testing/selftests/bpf/test_bpf_redirect_ifb.sh
>
> --
> Cc: "David S. Miller" <[email protected]>
> Cc: Jakub Kicinski <[email protected]>
> Cc: Alexei Starovoitov <[email protected]>
> Cc: Daniel Borkmann <[email protected]>
> Cc: Andrii Nakryiko <[email protected]>
> Cc: Martin KaFai Lau <[email protected]>
> Cc: Song Liu <[email protected]>
> Cc: Yonghong Song <[email protected]>
> Cc: John Fastabend <[email protected]>
> Cc: KP Singh <[email protected]>
> Cc: Eric Dumazet <[email protected]>
> Cc: Antoine Tenart <[email protected]>
> Cc: Alexander Lobakin <[email protected]>
> Cc: Wei Wang <[email protected]>
> Cc: Arnd Bergmann <[email protected]>
> --
> 2.27.0

Al

2021-12-08 15:54:05

by Tonghao Zhang

Subject: Re: [net v5 0/3] fix bpf_redirect to ifb netdev

On Wed, Dec 8, 2021 at 11:42 PM Alexander Lobakin
<[email protected]> wrote:
>
> From: Tonghao Zhang <[email protected]>
> Date: Wed, 8 Dec 2021 22:54:56 +0800
>
> > From: Tonghao Zhang <[email protected]>
> >
> > This patchset try to fix bpf_redirect to ifb netdev.
> > Prevent packets loopback and perfromance drop, add check
> > in sch egress.
>
> Please provide a changelog in the cover letter. With the links to
> your previous versions ideally.
> Otherwise it becomes difficult to understand what are the changes
> between them.
Hi Alexander
This version of patchset, 2/3 only updates the commit message. because the
example in the commit message is not a usual case.
There are no comments, so I sent them again.
I will provide a changelog in the next version or resend this version
again. Thanks.

> >
> > Tonghao Zhang (3):
> > net: core: set skb useful vars in __bpf_tx_skb
> > net: sched: add check tc_skip_classify in sch egress
> > selftests: bpf: add bpf_redirect to ifb
> >
> > net/core/dev.c | 3 +
> > net/core/filter.c | 12 ++-
> > tools/testing/selftests/bpf/Makefile | 1 +
> > .../bpf/progs/test_bpf_redirect_ifb.c | 13 ++++
> > .../selftests/bpf/test_bpf_redirect_ifb.sh | 73 +++++++++++++++++++
> > 5 files changed, 101 insertions(+), 1 deletion(-)
> > create mode 100644 tools/testing/selftests/bpf/progs/test_bpf_redirect_ifb.c
> > create mode 100755 tools/testing/selftests/bpf/test_bpf_redirect_ifb.sh
> >
> > --
> > Cc: "David S. Miller" <[email protected]>
> > Cc: Jakub Kicinski <[email protected]>
> > Cc: Alexei Starovoitov <[email protected]>
> > Cc: Daniel Borkmann <[email protected]>
> > Cc: Andrii Nakryiko <[email protected]>
> > Cc: Martin KaFai Lau <[email protected]>
> > Cc: Song Liu <[email protected]>
> > Cc: Yonghong Song <[email protected]>
> > Cc: John Fastabend <[email protected]>
> > Cc: KP Singh <[email protected]>
> > Cc: Eric Dumazet <[email protected]>
> > Cc: Antoine Tenart <[email protected]>
> > Cc: Alexander Lobakin <[email protected]>
> > Cc: Wei Wang <[email protected]>
> > Cc: Arnd Bergmann <[email protected]>
> > --
> > 2.27.0
>
> Al



--
Best regards, Tonghao