2022-05-10 21:57:26

by William Breathitt Gray

[permalink] [raw]
Subject: [PATCH 0/8] Utilize iomap interface for PC104 and friends

PC104 cards and similar devices do not need to access I/O ports directly
via inb()/outb() and can instead use the more typical I/O memory
ioread8()/iowrite8() accessor calls by first calling ioport_map(). This
patchset converts the relevant PC104/ISA card drivers to do such. With
these drivers now utilizing I/O memory accessor calls, work can be done
to consolidate some similar devices (e.g. 104-idio-16, pci-idio-16,
etc.) into a unified driver in a future patchset.

This patchset spawned from a suggestion made in another thread titled
"gpio: add HAS_IOPORT dependencies":
https://lore.kernel.org/all/[email protected]/

William Breathitt Gray (8):
counter: 104-quad-8: Utilize iomap interface
gpio: 104-dio-48e: Utilize iomap interface
gpio: 104-idi-48: Utilize iomap interface
gpio: 104-idio-16: Utilize iomap interface
gpio: gpio-mm: Utilize iomap interface
gpio: ws16c48: Utilize iomap interface
iio: adc: stx104: Utilize iomap interface
iio: dac: cio-dac: Utilize iomap interface

drivers/counter/104-quad-8.c | 169 +++++++++++++++++---------------
drivers/gpio/gpio-104-dio-48e.c | 63 ++++++------
drivers/gpio/gpio-104-idi-48.c | 27 ++---
drivers/gpio/gpio-104-idio-16.c | 33 ++++---
drivers/gpio/gpio-gpio-mm.c | 43 ++++----
drivers/gpio/gpio-ws16c48.c | 65 ++++++------
drivers/iio/adc/stx104.c | 56 ++++++-----
drivers/iio/dac/cio-dac.c | 14 +--
8 files changed, 248 insertions(+), 222 deletions(-)


base-commit: ce522ba9ef7e2d9fb22a39eb3371c0c64e2a433e
--
2.35.3



2022-05-14 02:37:14

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH 0/8] Utilize iomap interface for PC104 and friends

On Tue, May 10, 2022 at 7:31 PM William Breathitt Gray
<[email protected]> wrote:

> PC104 cards and similar devices do not need to access I/O ports directly
> via inb()/outb() and can instead use the more typical I/O memory
> ioread8()/iowrite8() accessor calls by first calling ioport_map(). This
> patchset converts the relevant PC104/ISA card drivers to do such. With
> these drivers now utilizing I/O memory accessor calls, work can be done
> to consolidate some similar devices (e.g. 104-idio-16, pci-idio-16,
> etc.) into a unified driver in a future patchset.
>
> This patchset spawned from a suggestion made in another thread titled
> "gpio: add HAS_IOPORT dependencies":
> https://lore.kernel.org/all/[email protected]/

The series:
Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2022-05-14 14:36:11

by Bartosz Golaszewski

[permalink] [raw]
Subject: Re: [PATCH 0/8] Utilize iomap interface for PC104 and friends

On Tue, May 10, 2022 at 7:31 PM William Breathitt Gray
<[email protected]> wrote:
>
> PC104 cards and similar devices do not need to access I/O ports directly
> via inb()/outb() and can instead use the more typical I/O memory
> ioread8()/iowrite8() accessor calls by first calling ioport_map(). This
> patchset converts the relevant PC104/ISA card drivers to do such. With
> these drivers now utilizing I/O memory accessor calls, work can be done
> to consolidate some similar devices (e.g. 104-idio-16, pci-idio-16,
> etc.) into a unified driver in a future patchset.
>
> This patchset spawned from a suggestion made in another thread titled
> "gpio: add HAS_IOPORT dependencies":
> https://lore.kernel.org/all/[email protected]/
>
> William Breathitt Gray (8):
> counter: 104-quad-8: Utilize iomap interface
> gpio: 104-dio-48e: Utilize iomap interface
> gpio: 104-idi-48: Utilize iomap interface
> gpio: 104-idio-16: Utilize iomap interface
> gpio: gpio-mm: Utilize iomap interface
> gpio: ws16c48: Utilize iomap interface
> iio: adc: stx104: Utilize iomap interface
> iio: dac: cio-dac: Utilize iomap interface
>
> drivers/counter/104-quad-8.c | 169 +++++++++++++++++---------------
> drivers/gpio/gpio-104-dio-48e.c | 63 ++++++------
> drivers/gpio/gpio-104-idi-48.c | 27 ++---
> drivers/gpio/gpio-104-idio-16.c | 33 ++++---
> drivers/gpio/gpio-gpio-mm.c | 43 ++++----
> drivers/gpio/gpio-ws16c48.c | 65 ++++++------
> drivers/iio/adc/stx104.c | 56 ++++++-----
> drivers/iio/dac/cio-dac.c | 14 +--
> 8 files changed, 248 insertions(+), 222 deletions(-)
>
>
> base-commit: ce522ba9ef7e2d9fb22a39eb3371c0c64e2a433e
> --
> 2.35.3
>

I don't see any dependencies so applied the GPIO part.

Bart

2022-05-15 07:20:38

by William Breathitt Gray

[permalink] [raw]
Subject: Re: [PATCH 0/8] Utilize iomap interface for PC104 and friends

On Sat, May 14, 2022 at 03:18:59PM +0100, Jonathan Cameron wrote:
> On Sat, 14 May 2022 14:57:49 +0200
> Bartosz Golaszewski <[email protected]> wrote:
>
> > On Tue, May 10, 2022 at 7:31 PM William Breathitt Gray
> > <[email protected]> wrote:
> > >
> > > PC104 cards and similar devices do not need to access I/O ports directly
> > > via inb()/outb() and can instead use the more typical I/O memory
> > > ioread8()/iowrite8() accessor calls by first calling ioport_map(). This
> > > patchset converts the relevant PC104/ISA card drivers to do such. With
> > > these drivers now utilizing I/O memory accessor calls, work can be done
> > > to consolidate some similar devices (e.g. 104-idio-16, pci-idio-16,
> > > etc.) into a unified driver in a future patchset.
> > >
> > > This patchset spawned from a suggestion made in another thread titled
> > > "gpio: add HAS_IOPORT dependencies":
> > > https://lore.kernel.org/all/[email protected]/
> > >
> > > William Breathitt Gray (8):
> > > counter: 104-quad-8: Utilize iomap interface
> > > gpio: 104-dio-48e: Utilize iomap interface
> > > gpio: 104-idi-48: Utilize iomap interface
> > > gpio: 104-idio-16: Utilize iomap interface
> > > gpio: gpio-mm: Utilize iomap interface
> > > gpio: ws16c48: Utilize iomap interface
> > > iio: adc: stx104: Utilize iomap interface
> > > iio: dac: cio-dac: Utilize iomap interface
> > >
> > > drivers/counter/104-quad-8.c | 169 +++++++++++++++++---------------
> > > drivers/gpio/gpio-104-dio-48e.c | 63 ++++++------
> > > drivers/gpio/gpio-104-idi-48.c | 27 ++---
> > > drivers/gpio/gpio-104-idio-16.c | 33 ++++---
> > > drivers/gpio/gpio-gpio-mm.c | 43 ++++----
> > > drivers/gpio/gpio-ws16c48.c | 65 ++++++------
> > > drivers/iio/adc/stx104.c | 56 ++++++-----
> > > drivers/iio/dac/cio-dac.c | 14 +--
> > > 8 files changed, 248 insertions(+), 222 deletions(-)
> > >
> > >
> > > base-commit: ce522ba9ef7e2d9fb22a39eb3371c0c64e2a433e
> > > --
> > > 2.35.3
> > >
> >
> > I don't see any dependencies so applied the GPIO part.
> Likewise, I've applied the IIO ones. Initially pushed out as testing
> to see if 0-day finds any issues. Given timing, we may well be looking
> at next merge window now though.
>
> Thanks,
>
> Jonathan
>
> >
> > Bart

Thanks, I'll pick up the remaining Counter patch in my tree. I'm going
to leave it in the tree as well until the next merge window to give some
time for others to test before it's released.

William Breathitt Gray


Attachments:
(No filename) (2.54 kB)
signature.asc (235.00 B)
Download all attachments

2022-05-15 10:32:27

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH 0/8] Utilize iomap interface for PC104 and friends

On Sat, 14 May 2022 14:57:49 +0200
Bartosz Golaszewski <[email protected]> wrote:

> On Tue, May 10, 2022 at 7:31 PM William Breathitt Gray
> <[email protected]> wrote:
> >
> > PC104 cards and similar devices do not need to access I/O ports directly
> > via inb()/outb() and can instead use the more typical I/O memory
> > ioread8()/iowrite8() accessor calls by first calling ioport_map(). This
> > patchset converts the relevant PC104/ISA card drivers to do such. With
> > these drivers now utilizing I/O memory accessor calls, work can be done
> > to consolidate some similar devices (e.g. 104-idio-16, pci-idio-16,
> > etc.) into a unified driver in a future patchset.
> >
> > This patchset spawned from a suggestion made in another thread titled
> > "gpio: add HAS_IOPORT dependencies":
> > https://lore.kernel.org/all/[email protected]/
> >
> > William Breathitt Gray (8):
> > counter: 104-quad-8: Utilize iomap interface
> > gpio: 104-dio-48e: Utilize iomap interface
> > gpio: 104-idi-48: Utilize iomap interface
> > gpio: 104-idio-16: Utilize iomap interface
> > gpio: gpio-mm: Utilize iomap interface
> > gpio: ws16c48: Utilize iomap interface
> > iio: adc: stx104: Utilize iomap interface
> > iio: dac: cio-dac: Utilize iomap interface
> >
> > drivers/counter/104-quad-8.c | 169 +++++++++++++++++---------------
> > drivers/gpio/gpio-104-dio-48e.c | 63 ++++++------
> > drivers/gpio/gpio-104-idi-48.c | 27 ++---
> > drivers/gpio/gpio-104-idio-16.c | 33 ++++---
> > drivers/gpio/gpio-gpio-mm.c | 43 ++++----
> > drivers/gpio/gpio-ws16c48.c | 65 ++++++------
> > drivers/iio/adc/stx104.c | 56 ++++++-----
> > drivers/iio/dac/cio-dac.c | 14 +--
> > 8 files changed, 248 insertions(+), 222 deletions(-)
> >
> >
> > base-commit: ce522ba9ef7e2d9fb22a39eb3371c0c64e2a433e
> > --
> > 2.35.3
> >
>
> I don't see any dependencies so applied the GPIO part.
Likewise, I've applied the IIO ones. Initially pushed out as testing
to see if 0-day finds any issues. Given timing, we may well be looking
at next merge window now though.

Thanks,

Jonathan

>
> Bart