2024-01-08 11:01:11

by Arnd Bergmann

Subject: [PATCH] ARM: davinci: always select CONFIG_CPU_ARM926T

From: Arnd Bergmann <[email protected]>

The select was lost by accident during the multiplatform conversion.
Any davinci-only

arm-linux-gnueabi-ld: arch/arm/mach-davinci/sleep.o: in function `CACHE_FLUSH':
(.text+0x168): undefined reference to `arm926_flush_kern_cache_all'

Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")
Signed-off-by: Arnd Bergmann <[email protected]>
---
I ran into this today for the first time after five years of randconfig testing
with the bug in place, so it is clearly very hard to hit.

It's an obvious fix, so I'm applying it to the soc/arm branch directly
for this week's pull requests.


arch/arm/mach-davinci/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
index 1c8bf56982e5..2a8a9fe46586 100644
--- a/arch/arm/mach-davinci/Kconfig
+++ b/arch/arm/mach-davinci/Kconfig
@@ -4,6 +4,7 @@ menuconfig ARCH_DAVINCI
bool "TI DaVinci"
depends on ARCH_MULTI_V5
depends on CPU_LITTLE_ENDIAN
+ select CPU_ARM926T
select DAVINCI_TIMER
select ZONE_DMA
select PM_GENERIC_DOMAINS if PM
--
2.39.2

2024-01-08 11:14:07

by Bartosz Golaszewski

Subject: Re: [PATCH] ARM: davinci: always select CONFIG_CPU_ARM926T

On Mon, Jan 8, 2024 at 12:01 PM Arnd Bergmann <[email protected]> wrote:
>
> From: Arnd Bergmann <[email protected]>
>
> The select was lost by accident during the multiplatform conversion.
> Any davinci-only
>
> arm-linux-gnueabi-ld: arch/arm/mach-davinci/sleep.o: in function `CACHE_FLUSH':
> (.text+0x168): undefined reference to `arm926_flush_kern_cache_all'
>
> Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> I ran into this today for the first time after five years of randconfig testing
> with the bug in place, so it is clearly very hard to hit.
>
> It's an obvious fix, so I'm applying it to the soc/arm branch directly
> for this week's pull requests.
>
>
> arch/arm/mach-davinci/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
> index 1c8bf56982e5..2a8a9fe46586 100644
> --- a/arch/arm/mach-davinci/Kconfig
> +++ b/arch/arm/mach-davinci/Kconfig
> @@ -4,6 +4,7 @@ menuconfig ARCH_DAVINCI
> bool "TI DaVinci"
> depends on ARCH_MULTI_V5
> depends on CPU_LITTLE_ENDIAN
> + select CPU_ARM926T
> select DAVINCI_TIMER
> select ZONE_DMA
> select PM_GENERIC_DOMAINS if PM
> --
> 2.39.2
>

Acked-by: Bartosz Golaszewski <[email protected]>