2024-03-05 00:26:10

by Kent Gibson

Subject: [PATCH] selftest: gpio: remove obsolete gpio-mockup test

With the removal of the ARCH_NR_GPIOS, the number of available GPIOs
is effectively unlimited, causing the gpio-mockup module load failure
test that overflowed the number of GPIOs to unexpectedly succeed, and
so fail.

The test is no longer relevant so remove it.
Promote the "no lines defined" test so there is still one load
failure test in the basic set.

Fixes: 7b61212f2a07 ("gpiolib: Get rid of ARCH_NR_GPIOS")
Reported-by: Pengfei Xu <[email protected]>
Reported-by: Yi Lai <[email protected]>
Closes: https://lore.kernel.org/linux-gpio/[email protected]/
Signed-off-by: Kent Gibson <[email protected]>
---
tools/testing/selftests/gpio/gpio-mockup.sh | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/tools/testing/selftests/gpio/gpio-mockup.sh b/tools/testing/selftests/gpio/gpio-mockup.sh
index 0d6c5f7f95d2..fc2dd4c24d06 100755
--- a/tools/testing/selftests/gpio/gpio-mockup.sh
+++ b/tools/testing/selftests/gpio/gpio-mockup.sh
@@ -377,13 +377,10 @@ if [ "$full_test" ]; then
insmod_test "0,32,32,44,-1,22,-1,31" 32 12 22 31
fi
echo "2. Module load error tests"
-echo "2.1 gpio overflow"
-# Currently: The max number of gpio(1024) is defined in arm architecture.
-insmod_test "-1,1024"
+echo "2.1 no lines defined"
+insmod_test "0,0"
if [ "$full_test" ]; then
- echo "2.2 no lines defined"
- insmod_test "0,0"
- echo "2.3 ignore range overlap"
+ echo "2.2 ignore range overlap"
insmod_test "0,32,0,1" 32
insmod_test "0,32,1,5" 32
insmod_test "0,32,30,35" 32
--
2.39.2

2024-03-05 15:52:46

by Christophe Leroy

Subject: Re: [PATCH] selftest: gpio: remove obsolete gpio-mockup test

Le 05/03/2024 à 01:21, Kent Gibson a écrit :
> [Vous ne recevez pas souvent de courriers de [email protected]. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ]
>
> With the removal of the ARCH_NR_GPIOS, the number of available GPIOs
> is effectively unlimited, causing the gpio-mockup module load failure
> test that overflowed the number of GPIOs to unexpectedly succeed, and
> so fail.
>
> The test is no longer relevant so remove it.
> Promote the "no lines defined" test so there is still one load
> failure test in the basic set.
>
> Fixes: 7b61212f2a07 ("gpiolib: Get rid of ARCH_NR_GPIOS")
> Reported-by: Pengfei Xu <[email protected]>
> Reported-by: Yi Lai <[email protected]>
> Closes: https://lore.kernel.org/linux-gpio/[email protected]/
> Signed-off-by: Kent Gibson <[email protected]>

Acked-by: Christophe Leroy <[email protected]>

> ---
> tools/testing/selftests/gpio/gpio-mockup.sh | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/tools/testing/selftests/gpio/gpio-mockup.sh b/tools/testing/selftests/gpio/gpio-mockup.sh
> index 0d6c5f7f95d2..fc2dd4c24d06 100755
> --- a/tools/testing/selftests/gpio/gpio-mockup.sh
> +++ b/tools/testing/selftests/gpio/gpio-mockup.sh
> @@ -377,13 +377,10 @@ if [ "$full_test" ]; then
> insmod_test "0,32,32,44,-1,22,-1,31" 32 12 22 31
> fi
> echo "2. Module load error tests"
> -echo "2.1 gpio overflow"
> -# Currently: The max number of gpio(1024) is defined in arm architecture.
> -insmod_test "-1,1024"
> +echo "2.1 no lines defined"
> +insmod_test "0,0"
> if [ "$full_test" ]; then
> - echo "2.2 no lines defined"
> - insmod_test "0,0"
> - echo "2.3 ignore range overlap"
> + echo "2.2 ignore range overlap"
> insmod_test "0,32,0,1" 32
> insmod_test "0,32,1,5" 32
> insmod_test "0,32,30,35" 32
> --
> 2.39.2
>

2024-03-05 21:31:57

by Bartosz Golaszewski

Subject: Re: [PATCH] selftest: gpio: remove obsolete gpio-mockup test

On Tue, Mar 5, 2024 at 1:26 AM Kent Gibson <[email protected]> wrote:
>
> With the removal of the ARCH_NR_GPIOS, the number of available GPIOs
> is effectively unlimited, causing the gpio-mockup module load failure
> test that overflowed the number of GPIOs to unexpectedly succeed, and
> so fail.
>
> The test is no longer relevant so remove it.
> Promote the "no lines defined" test so there is still one load
> failure test in the basic set.
>
> Fixes: 7b61212f2a07 ("gpiolib: Get rid of ARCH_NR_GPIOS")
> Reported-by: Pengfei Xu <[email protected]>
> Reported-by: Yi Lai <[email protected]>
> Closes: https://lore.kernel.org/linux-gpio/[email protected]/
> Signed-off-by: Kent Gibson <[email protected]>
> ---
> tools/testing/selftests/gpio/gpio-mockup.sh | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/tools/testing/selftests/gpio/gpio-mockup.sh b/tools/testing/selftests/gpio/gpio-mockup.sh
> index 0d6c5f7f95d2..fc2dd4c24d06 100755
> --- a/tools/testing/selftests/gpio/gpio-mockup.sh
> +++ b/tools/testing/selftests/gpio/gpio-mockup.sh
> @@ -377,13 +377,10 @@ if [ "$full_test" ]; then
> insmod_test "0,32,32,44,-1,22,-1,31" 32 12 22 31
> fi
> echo "2. Module load error tests"
> -echo "2.1 gpio overflow"
> -# Currently: The max number of gpio(1024) is defined in arm architecture.
> -insmod_test "-1,1024"
> +echo "2.1 no lines defined"
> +insmod_test "0,0"
> if [ "$full_test" ]; then
> - echo "2.2 no lines defined"
> - insmod_test "0,0"
> - echo "2.3 ignore range overlap"
> + echo "2.2 ignore range overlap"
> insmod_test "0,32,0,1" 32
> insmod_test "0,32,1,5" 32
> insmod_test "0,32,30,35" 32
> --
> 2.39.2
>
>

Applied, thanks!

Bart