2018-08-17 00:49:26

by Bjorn Andersson

Subject: [PATCH] remoteproc/davinci: Use %zx for formating size_t

da8xx_rproc_mem size is of type size_t, so use %zx to format the debug
print of it to avoid a compile warning.

Signed-off-by: Bjorn Andersson <[email protected]>
---
drivers/remoteproc/da8xx_remoteproc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
index e230bef71be1..d200334577f6 100644
--- a/drivers/remoteproc/da8xx_remoteproc.c
+++ b/drivers/remoteproc/da8xx_remoteproc.c
@@ -226,7 +226,7 @@ static int da8xx_rproc_get_internal_memories(struct platform_device *pdev,
res->start & DA8XX_RPROC_LOCAL_ADDRESS_MASK;
drproc->mem[i].size = resource_size(res);

- dev_dbg(dev, "memory %8s: bus addr %pa size 0x%x va %p da 0x%x\n",
+ dev_dbg(dev, "memory %8s: bus addr %pa size 0x%zx va %p da 0x%x\n",
mem_names[i], &drproc->mem[i].bus_addr,
drproc->mem[i].size, drproc->mem[i].cpu_addr,
drproc->mem[i].dev_addr);
--
2.18.0

2018-08-17 01:53:44

by Suman Anna

Subject: Re: [PATCH] remoteproc/davinci: Use %zx for formating size_t

On 08/16/2018 07:49 PM, Bjorn Andersson wrote:
> da8xx_rproc_mem size is of type size_t, so use %zx to format the debug
> print of it to avoid a compile warning.
>

Thanks for the improvement,

Acked-by: Suman Anna <[email protected]>

> Signed-off-by: Bjorn Andersson <[email protected]>
> ---
> drivers/remoteproc/da8xx_remoteproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
> index e230bef71be1..d200334577f6 100644
> --- a/drivers/remoteproc/da8xx_remoteproc.c
> +++ b/drivers/remoteproc/da8xx_remoteproc.c
> @@ -226,7 +226,7 @@ static int da8xx_rproc_get_internal_memories(struct platform_device *pdev,
> res->start & DA8XX_RPROC_LOCAL_ADDRESS_MASK;
> drproc->mem[i].size = resource_size(res);
>
> - dev_dbg(dev, "memory %8s: bus addr %pa size 0x%x va %p da 0x%x\n",
> + dev_dbg(dev, "memory %8s: bus addr %pa size 0x%zx va %p da 0x%x\n",
> mem_names[i], &drproc->mem[i].bus_addr,
> drproc->mem[i].size, drproc->mem[i].cpu_addr,
> drproc->mem[i].dev_addr);
>

2018-08-17 07:41:02

by Bartosz Golaszewski

Subject: Re: [PATCH] remoteproc/davinci: Use %zx for formating size_t

2018-08-17 2:49 GMT+02:00 Bjorn Andersson <[email protected]>:
> da8xx_rproc_mem size is of type size_t, so use %zx to format the debug
> print of it to avoid a compile warning.
>
> Signed-off-by: Bjorn Andersson <[email protected]>
> ---
> drivers/remoteproc/da8xx_remoteproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
> index e230bef71be1..d200334577f6 100644
> --- a/drivers/remoteproc/da8xx_remoteproc.c
> +++ b/drivers/remoteproc/da8xx_remoteproc.c
> @@ -226,7 +226,7 @@ static int da8xx_rproc_get_internal_memories(struct platform_device *pdev,
> res->start & DA8XX_RPROC_LOCAL_ADDRESS_MASK;
> drproc->mem[i].size = resource_size(res);
>
> - dev_dbg(dev, "memory %8s: bus addr %pa size 0x%x va %p da 0x%x\n",
> + dev_dbg(dev, "memory %8s: bus addr %pa size 0x%zx va %p da 0x%x\n",
> mem_names[i], &drproc->mem[i].bus_addr,
> drproc->mem[i].size, drproc->mem[i].cpu_addr,
> drproc->mem[i].dev_addr);
> --
> 2.18.0
>

Reviewed-by: Bartosz Golaszewski <[email protected]>

Can you also pick up this patch[1] for v4.19? David Lechner already
has a patch queued for v4.20 that depends on this one.

Thanks,
Bartosz

[1] https://patchwork.kernel.org/patch/10479365/

2018-08-17 08:07:03

by Sekhar Nori

Subject: Re: [PATCH] remoteproc/davinci: Use %zx for formating size_t

On Friday 17 August 2018 01:09 PM, Bartosz Golaszewski wrote:
> 2018-08-17 2:49 GMT+02:00 Bjorn Andersson <[email protected]>:
>> da8xx_rproc_mem size is of type size_t, so use %zx to format the debug
>> print of it to avoid a compile warning.
>>
>> Signed-off-by: Bjorn Andersson <[email protected]>
>> ---
>> drivers/remoteproc/da8xx_remoteproc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
>> index e230bef71be1..d200334577f6 100644
>> --- a/drivers/remoteproc/da8xx_remoteproc.c
>> +++ b/drivers/remoteproc/da8xx_remoteproc.c
>> @@ -226,7 +226,7 @@ static int da8xx_rproc_get_internal_memories(struct platform_device *pdev,
>> res->start & DA8XX_RPROC_LOCAL_ADDRESS_MASK;
>> drproc->mem[i].size = resource_size(res);
>>
>> - dev_dbg(dev, "memory %8s: bus addr %pa size 0x%x va %p da 0x%x\n",
>> + dev_dbg(dev, "memory %8s: bus addr %pa size 0x%zx va %p da 0x%x\n",
>> mem_names[i], &drproc->mem[i].bus_addr,
>> drproc->mem[i].size, drproc->mem[i].cpu_addr,
>> drproc->mem[i].dev_addr);
>> --
>> 2.18.0
>>
>
> Reviewed-by: Bartosz Golaszewski <[email protected]>
>
> Can you also pick up this patch[1] for v4.19? David Lechner already
> has a patch queued for v4.20 that depends on this one.

Looks like Bjorn added it to next yesterday.

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=b2201ee554a5811f569f31280b0079e7d6177606

Thanks,
Sekhar