2024-06-11 14:03:54

by Andrew Davis

Subject: [PATCH] dt-bindings: gpio: lsi,zevio-gpio: convert to YAML

Convert Zevio GPIO controller bindings to DT schema.

Changes during conversion:
- Add used but undocumented interrupts property

Signed-off-by: Andrew Davis <[email protected]>
---
.../devicetree/bindings/gpio/gpio-zevio.txt | 16 -------
.../bindings/gpio/lsi,zevio-gpio.yaml | 46 +++++++++++++++++++
2 files changed, 46 insertions(+), 16 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-zevio.txt
create mode 100644 Documentation/devicetree/bindings/gpio/lsi,zevio-gpio.yaml

diff --git a/Documentation/devicetree/bindings/gpio/gpio-zevio.txt b/Documentation/devicetree/bindings/gpio/gpio-zevio.txt
deleted file mode 100644
index a37bd9ae27307..0000000000000
--- a/Documentation/devicetree/bindings/gpio/gpio-zevio.txt
+++ /dev/null
@@ -1,16 +0,0 @@
-Zevio GPIO controller
-
-Required properties:
-- compatible: Should be "lsi,zevio-gpio"
-- reg: Address and length of the register set for the device
-- #gpio-cells: Should be two. The first cell is the pin number and the
- second cell is used to specify optional parameters (currently unused).
-- gpio-controller: Marks the device node as a GPIO controller.
-
-Example:
- gpio: gpio@90000000 {
- compatible = "lsi,zevio-gpio";
- reg = <0x90000000 0x1000>;
- gpio-controller;
- #gpio-cells = <2>;
- };
diff --git a/Documentation/devicetree/bindings/gpio/lsi,zevio-gpio.yaml b/Documentation/devicetree/bindings/gpio/lsi,zevio-gpio.yaml
new file mode 100644
index 0000000000000..542b5f9a495d9
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/lsi,zevio-gpio.yaml
@@ -0,0 +1,46 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpio/lsi,zevio-gpio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Zevio GPIO controller
+
+maintainers:
+ - Andrew Davis <[email protected]>
+
+properties:
+ compatible:
+ const: lsi,zevio-gpio
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ gpio-controller: true
+
+ "#gpio-cells":
+ description: The first cell is the pin number and the second cell is used
+ to specify optional parameters (currently unused).
+ const: 2
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - gpio-controller
+ - "#gpio-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ gpio: gpio@90000000 {
+ compatible = "lsi,zevio-gpio";
+ reg = <0x90000000 0x1000>;
+ interrupts = <7>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
--
2.39.2

2024-06-11 20:35:33

by Rob Herring (Arm)

Subject: Re: [PATCH] dt-bindings: gpio: lsi,zevio-gpio: convert to YAML

On Tue, Jun 11, 2024 at 09:00:34AM -0500, Andrew Davis wrote:
> Convert Zevio GPIO controller bindings to DT schema.
>
> Changes during conversion:
> - Add used but undocumented interrupts property

An interrupt on a GPIO controller generally means it is also an
interrupt-controller. Do you need to add those properties too?

>
> Signed-off-by: Andrew Davis <[email protected]>
> ---
> .../devicetree/bindings/gpio/gpio-zevio.txt | 16 -------
> .../bindings/gpio/lsi,zevio-gpio.yaml | 46 +++++++++++++++++++
> 2 files changed, 46 insertions(+), 16 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-zevio.txt
> create mode 100644 Documentation/devicetree/bindings/gpio/lsi,zevio-gpio.yaml

Otherwise,

Reviewed-by: Rob Herring (Arm) <[email protected]>

2024-06-12 14:27:59

by Bartosz Golaszewski

Subject: Re: [PATCH] dt-bindings: gpio: lsi,zevio-gpio: convert to YAML

On Tue, Jun 11, 2024 at 4:00 PM Andrew Davis <[email protected]> wrote:
>
> Convert Zevio GPIO controller bindings to DT schema.
>
> Changes during conversion:
> - Add used but undocumented interrupts property
>
> Signed-off-by: Andrew Davis <[email protected]>
> ---

The conversion of this file by another author is already in next as
commit e4608bbccf2b ("dt-bindings: gpio: lsi,zevio-gpio: convert to
dtschema").

Bart