2024-01-17 14:30:14

by Mario Limonciello

Subject: [PATCH] gpiolib: acpi: Ignore touchpad wakeup on GPD G1619-04

Spurious wakeups are reported on the GPD G1619-04 which
can be absolved by programming the GPIO to ignore wakeups.

Cc: [email protected]
Reported-and-tested-by: George Melikov <[email protected]>
Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3073
Signed-off-by: Mario Limonciello <[email protected]>
---
drivers/gpio/gpiolib-acpi.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
index 88066826d8e5..cd3e9657cc36 100644
--- a/drivers/gpio/gpiolib-acpi.c
+++ b/drivers/gpio/gpiolib-acpi.c
@@ -1651,6 +1651,20 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] __initconst = {
.ignore_interrupt = "INT33FC:00@3",
},
},
+ {
+ /*
+ * Spurious wakeups from TP_ATTN# pin
+ * Found in BIOS 0.35
+ * https://gitlab.freedesktop.org/drm/amd/-/issues/3073
+ */
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "GPD"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "G1619-04"),
+ },
+ .driver_data = &(struct acpi_gpiolib_dmi_quirk) {
+ .ignore_wake = "PNP0C50:00@8",
+ },
+ },
{} /* Terminating entry */
};

--
2.34.1

2024-01-21 17:49:44

by Andy Shevchenko

Subject: Re: [PATCH] gpiolib: acpi: Ignore touchpad wakeup on GPD G1619-04

On Wed, Jan 17, 2024 at 08:29:42AM -0600, Mario Limonciello wrote:
> Spurious wakeups are reported on the GPD G1619-04 which
> can be absolved by programming the GPIO to ignore wakeups.

Reviewed-by: Andy Shevchenko <[email protected]>


--
With Best Regards,
Andy Shevchenko

2024-01-22 10:22:29

by Bartosz Golaszewski

Subject: Re: [PATCH] gpiolib: acpi: Ignore touchpad wakeup on GPD G1619-04

On Wed, Jan 17, 2024 at 3:29 PM Mario Limonciello
<[email protected]> wrote:
>
> Spurious wakeups are reported on the GPD G1619-04 which
> can be absolved by programming the GPIO to ignore wakeups.
>
> Cc: [email protected]
> Reported-and-tested-by: George Melikov <[email protected]>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3073
> Signed-off-by: Mario Limonciello <[email protected]>
> ---
> drivers/gpio/gpiolib-acpi.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c
> index 88066826d8e5..cd3e9657cc36 100644
> --- a/drivers/gpio/gpiolib-acpi.c
> +++ b/drivers/gpio/gpiolib-acpi.c
> @@ -1651,6 +1651,20 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] __initconst = {
> .ignore_interrupt = "INT33FC:00@3",
> },
> },
> + {
> + /*
> + * Spurious wakeups from TP_ATTN# pin
> + * Found in BIOS 0.35
> + * https://gitlab.freedesktop.org/drm/amd/-/issues/3073
> + */
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "GPD"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "G1619-04"),
> + },
> + .driver_data = &(struct acpi_gpiolib_dmi_quirk) {
> + .ignore_wake = "PNP0C50:00@8",
> + },
> + },
> {} /* Terminating entry */
> };
>
> --
> 2.34.1
>

Queued for fixes, thanks!

Bart