2022-03-28 11:38:16

by Caleb Connolly

Subject: [PATCH 3/4] gpio/rockchip: handle deferring input-enable pinconfs

Add support for deferred PIN_CONFIG_INPUT_ENABLE handling.

Signed-off-by: Caleb Connolly <[email protected]>
---
drivers/gpio/gpio-rockchip.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
index bcf5214e3586..e342a6dc4c6c 100644
--- a/drivers/gpio/gpio-rockchip.c
+++ b/drivers/gpio/gpio-rockchip.c
@@ -760,6 +760,11 @@ static int rockchip_gpio_probe(struct platform_device *pdev)
dev_warn(dev, "setting output pin %u to %u failed\n", cfg->pin,
cfg->arg);
break;
+ case PIN_CONFIG_INPUT_ENABLE:
+ ret = rockchip_gpio_direction_input(&bank->gpio_chip, cfg->pin);
+ if (ret)
+ dev_warn(dev, "setting input pin %u failed\n", cfg->pin);
+ break;
default:
dev_warn(dev, "unknown deferred config param %d\n", cfg->param);
break;
--
2.35.1

2022-04-19 11:37:22

by Bartosz Golaszewski

Subject: Re: [PATCH 3/4] gpio/rockchip: handle deferring input-enable pinconfs

On Mon, Mar 28, 2022 at 2:50 AM Caleb Connolly <[email protected]> wrote:
>
> Add support for deferred PIN_CONFIG_INPUT_ENABLE handling.
>
> Signed-off-by: Caleb Connolly <[email protected]>
> ---
> drivers/gpio/gpio-rockchip.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
> index bcf5214e3586..e342a6dc4c6c 100644
> --- a/drivers/gpio/gpio-rockchip.c
> +++ b/drivers/gpio/gpio-rockchip.c
> @@ -760,6 +760,11 @@ static int rockchip_gpio_probe(struct platform_device *pdev)
> dev_warn(dev, "setting output pin %u to %u failed\n", cfg->pin,
> cfg->arg);
> break;
> + case PIN_CONFIG_INPUT_ENABLE:
> + ret = rockchip_gpio_direction_input(&bank->gpio_chip, cfg->pin);
> + if (ret)
> + dev_warn(dev, "setting input pin %u failed\n", cfg->pin);
> + break;
> default:
> dev_warn(dev, "unknown deferred config param %d\n", cfg->param);
> break;
> --
> 2.35.1
>

Does this depend on patches 1 & 2 or does patch 4 depend on this one? If so:

Acked-by: Bartosz Golaszewski <[email protected]>

Otherwise I can take it through the GPIO tree.

Bart