2023-10-13 00:30:07

by Edson Juliano Drosdeck

[permalink] [raw]
Subject: [PATCH] staging: rtl8723bs: Remove unnecessary bracks

Warning found by checkpatch.pl script.Remove bracks than are not necessary for
a single statement blocks in hal/odm.c

Signed-off-by: Edson Juliano Drosdeck <[email protected]>
---
drivers/staging/rtl8723bs/hal/odm.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/odm.c b/drivers/staging/rtl8723bs/hal/odm.c
index ea3b4cd32360..b1397990680f 100644
--- a/drivers/staging/rtl8723bs/hal/odm.c
+++ b/drivers/staging/rtl8723bs/hal/odm.c
@@ -417,13 +417,11 @@ static void odm_RefreshRateAdaptiveMaskCE(struct dm_odm_t *pDM_Odm)
u8 i;
struct adapter *padapter = pDM_Odm->Adapter;

- if (padapter->bDriverStopped) {
+ if (padapter->bDriverStopped)
return;
- }

- if (!pDM_Odm->bUseRAMask) {
+ if (!pDM_Odm->bUseRAMask)
return;
- }

for (i = 0; i < ODM_ASSOCIATE_ENTRY_NUM; i++) {
PSTA_INFO_T pstat = pDM_Odm->pODM_StaInfo[i];
@@ -461,9 +459,8 @@ static void odm_RefreshRateAdaptiveMaskCE(struct dm_odm_t *pDM_Odm)
static void odm_RefreshRateAdaptiveMask(struct dm_odm_t *pDM_Odm)
{

- if (!(pDM_Odm->SupportAbility & ODM_BB_RA_MASK)) {
+ if (!(pDM_Odm->SupportAbility & ODM_BB_RA_MASK))
return;
- }
odm_RefreshRateAdaptiveMaskCE(pDM_Odm);
}

--
2.39.2


2023-10-15 16:19:36

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] staging: rtl8723bs: Remove unnecessary bracks

On Thu, Oct 12, 2023 at 09:29:44PM -0300, Edson Juliano Drosdeck wrote:
> Warning found by checkpatch.pl script.Remove bracks than are not necessary for
> a single statement blocks in hal/odm.c

"bracks"? I think it is called "brackets", right?

thanks,

greg k-h

2023-10-15 16:26:22

by Edson Juliano Drosdeck

[permalink] [raw]
Subject: Re: [PATCH] staging: rtl8723bs: Remove unnecessary bracks

Thanks for the feedback.


Em dom., 15 de out. de 2023 às 13:19, Greg KH
<[email protected]> escreveu:
>
> On Thu, Oct 12, 2023 at 09:29:44PM -0300, Edson Juliano Drosdeck wrote:
> > Warning found by checkpatch.pl script.Remove bracks than are not necessary for
> > a single statement blocks in hal/odm.c
>
> "bracks"? I think it is called "brackets", right?
>
> thanks,
>
> greg k-h