2022-04-06 06:12:40

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v2] staging: rtl8723bs: fix indentation

On Tue, Apr 05, 2022 at 11:09:12AM -0400, Sevinj Aghayeva wrote:
> Adhere to Linux kernel coding style.
>
> Reported by checkpatch:
>
> WARNING: suspect code indent for conditional statements

You are also removing unneeded comments, right? Please explain that as
the documentation link the bot pointed you to showed.

thanks,

greg k-h


2022-04-06 14:40:18

by Sevinj Aghayeva

[permalink] [raw]
Subject: Re: [PATCH v2] staging: rtl8723bs: fix indentation

On Tue, Apr 5, 2022 at 11:17 AM Greg Kroah-Hartman
<[email protected]> wrote:
>
> On Tue, Apr 05, 2022 at 11:09:12AM -0400, Sevinj Aghayeva wrote:
> > Adhere to Linux kernel coding style.
> >
> > Reported by checkpatch:
> >
> > WARNING: suspect code indent for conditional statements
>
> You are also removing unneeded comments, right? Please explain that as
> the documentation link the bot pointed you to showed.

I specified that under the --- line:

v1 -> v2: Remove the comments that became irrelevant with proper indentation.

>
> thanks,
>
> greg k-h



--

Sevinj.Aghayeva