2023-11-21 15:05:23

by Vincent Mailhol

[permalink] [raw]
Subject: Re: [PATCH v10 0/2] can: esd: add support for esd GmbH PCIe/402 CAN interface

On Tue. 21 Nov. 2023 at 02:57, Stefan Mätje <[email protected]> wrote:
> The purpose of this patch is to introduce a new CAN driver to support
> the esd GmbH 402 family of CAN interface boards. The hardware design
> is based on a CAN controller implemented in a FPGA attached to a
> PCIe link.
>
> More information on these boards can be found following the links
> included in the commit message.
>
> This patch supports all boards but will operate the CAN-FD capable
> boards only in Classic-CAN mode. The CAN-FD support will be added
> when the initial patch has stabilized.
>
> The patch is reuses the previous work of my former colleague:
> Link: https://lore.kernel.org/linux-can/[email protected]/
>
>
> The patch is based on the linux-can-next main branch.

I left one nitpick in patch 1 and two nitpicks in patch 2. Regardless,
for the full series:

Reviewed-by: Vincent Mailhol <[email protected]>