2024-04-12 18:51:22

by Andy Shevchenko

Subject: [PATCH net-next v1 1/1] can: mcp251x: Fix up includes

This driver is including the legacy GPIO header <linux/gpio.h>
but the only thing it is using from that header is the wrong
define for GPIOF_DIR_OUT.

Fix it up by using GPIO_LINE_DIRECTION_* macros respectively.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/net/can/spi/mcp251x.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/can/spi/mcp251x.c b/drivers/net/can/spi/mcp251x.c
index 79c4bab5f724..643974b3f329 100644
--- a/drivers/net/can/spi/mcp251x.c
+++ b/drivers/net/can/spi/mcp251x.c
@@ -28,7 +28,6 @@
#include <linux/device.h>
#include <linux/ethtool.h>
#include <linux/freezer.h>
-#include <linux/gpio.h>
#include <linux/gpio/driver.h>
#include <linux/interrupt.h>
#include <linux/io.h>
@@ -482,9 +481,9 @@ static int mcp251x_gpio_get_direction(struct gpio_chip *chip,
unsigned int offset)
{
if (mcp251x_gpio_is_input(offset))
- return GPIOF_DIR_IN;
+ return GPIO_LINE_DIRECTION_IN;

- return GPIOF_DIR_OUT;
+ return GPIO_LINE_DIRECTION_OUT;
}

static int mcp251x_gpio_get(struct gpio_chip *chip, unsigned int offset)
--
2.43.0.rc1.1336.g36b5255a03ac

2024-04-13 09:02:52

by Vincent MAILHOL

Subject: Re: [PATCH net-next v1 1/1] can: mcp251x: Fix up includes

On Sat. 13 Apr. 2024 at 02:33, Andy Shevchenko
<[email protected]> wrote:
> This driver is including the legacy GPIO header <linux/gpio.h>
> but the only thing it is using from that header is the wrong
> define for GPIOF_DIR_OUT.
>
> Fix it up by using GPIO_LINE_DIRECTION_* macros respectively.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Thank you for the patch.

Reviewed-by: Vincent Mailhol <[email protected]>