2023-10-12 04:35:34

by Muhammad Muzammil

[permalink] [raw]
Subject: [PATCH v2] drivers: net: wwan: wwan_core.c: resolved spelling mistake

resolved typing mistake from devce to device

changes since v1:
- resolved another typing mistake from concurent to
concurrent

Signed-off-by: Muhammad Muzammil <[email protected]>
---
drivers/net/wwan/wwan_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c
index 87df60916960..72e01e550a16 100644
--- a/drivers/net/wwan/wwan_core.c
+++ b/drivers/net/wwan/wwan_core.c
@@ -302,7 +302,7 @@ static void wwan_remove_dev(struct wwan_device *wwandev)

static const struct {
const char * const name; /* Port type name */
- const char * const devsuf; /* Port devce name suffix */
+ const char * const devsuf; /* Port device name suffix */
} wwan_port_types[WWAN_PORT_MAX + 1] = {
[WWAN_PORT_AT] = {
.name = "AT",
@@ -1184,7 +1184,7 @@ void wwan_unregister_ops(struct device *parent)
*/
put_device(&wwandev->dev);

- rtnl_lock(); /* Prevent concurent netdev(s) creation/destroying */
+ rtnl_lock(); /* Prevent concurrent netdev(s) creation/destroying */

/* Remove all child netdev(s), using batch removing */
device_for_each_child(&wwandev->dev, &kill_list,
--
2.27.0


2023-10-12 06:18:14

by Muhammad Muzammil

[permalink] [raw]
Subject: Re: [PATCH v2] drivers: net: wwan: wwan_core.c: resolved spelling mistake

Hi Simon,

I created the v2 patch but I do not know why it was not recognized. I
have attached the patch file here.

On Thu, Oct 12, 2023 at 9:35 AM Muhammad Muzammil
<[email protected]> wrote:
>
> resolved typing mistake from devce to device
>
> changes since v1:
> - resolved another typing mistake from concurent to
> concurrent
>
> Signed-off-by: Muhammad Muzammil <[email protected]>
> ---
> drivers/net/wwan/wwan_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c
> index 87df60916960..72e01e550a16 100644
> --- a/drivers/net/wwan/wwan_core.c
> +++ b/drivers/net/wwan/wwan_core.c
> @@ -302,7 +302,7 @@ static void wwan_remove_dev(struct wwan_device *wwandev)
>
> static const struct {
> const char * const name; /* Port type name */
> - const char * const devsuf; /* Port devce name suffix */
> + const char * const devsuf; /* Port device name suffix */
> } wwan_port_types[WWAN_PORT_MAX + 1] = {
> [WWAN_PORT_AT] = {
> .name = "AT",
> @@ -1184,7 +1184,7 @@ void wwan_unregister_ops(struct device *parent)
> */
> put_device(&wwandev->dev);
>
> - rtnl_lock(); /* Prevent concurent netdev(s) creation/destroying */
> + rtnl_lock(); /* Prevent concurrent netdev(s) creation/destroying */
>
> /* Remove all child netdev(s), using batch removing */
> device_for_each_child(&wwandev->dev, &kill_list,
> --
> 2.27.0
>


Attachments:
v2-0001-drivers-net-wwan-wwan_core.c-resolved-spelling-mi.patch (1.40 kB)

2023-10-12 17:04:13

by Loic Poulain

[permalink] [raw]
Subject: Re: [PATCH v2] drivers: net: wwan: wwan_core.c: resolved spelling mistake

Hi Muhammad,

On Thu, 12 Oct 2023 at 06:35, Muhammad Muzammil
<[email protected]> wrote:
>
> resolved typing mistake from devce to device
>
> changes since v1:

Change log should not be part of the commit message, simply drop the above line.

> - resolved another typing mistake from concurent to
> concurrent
>
> Signed-off-by: Muhammad Muzammil <[email protected]>
> ---

You can put your change log here, e.g:
v1: Fix 'concurrent' typo...

> drivers/net/wwan/wwan_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c
> index 87df60916960..72e01e550a16 100644
> --- a/drivers/net/wwan/wwan_core.c
> +++ b/drivers/net/wwan/wwan_core.c
> @@ -302,7 +302,7 @@ static void wwan_remove_dev(struct wwan_device *wwandev)
>
> static const struct {
> const char * const name; /* Port type name */
> - const char * const devsuf; /* Port devce name suffix */
> + const char * const devsuf; /* Port device name suffix */
> } wwan_port_types[WWAN_PORT_MAX + 1] = {
> [WWAN_PORT_AT] = {
> .name = "AT",
> @@ -1184,7 +1184,7 @@ void wwan_unregister_ops(struct device *parent)
> */
> put_device(&wwandev->dev);
>
> - rtnl_lock(); /* Prevent concurent netdev(s) creation/destroying */
> + rtnl_lock(); /* Prevent concurrent netdev(s) creation/destroying */
>
> /* Remove all child netdev(s), using batch removing */
> device_for_each_child(&wwandev->dev, &kill_list,
> --
> 2.27.0
>