2022-05-16 06:52:43

by FanJun Kong

Subject: [PATCH] mm/page_owner.c: Add missing __initdata attribute

From: Fanjun Kong <[email protected]>

This patch fix two issues:
1. Add __initdata attribute according to include/linux/init.h:
> For initialized data:
> You should insert __initdata between the variable name and equal
> sign followed by value

2. Fix below error reported by checkpatch.pl:
ERROR: do not initialise statics to false

Special thanks to Muchun Song :)

Suggested-by: Muchun Song <[email protected]>
Signed-off-by: Fanjun Kong <[email protected]>
---
mm/page_owner.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/page_owner.c b/mm/page_owner.c
index 9185ff4eacb6..e4c6f3f1695b 100644
--- a/mm/page_owner.c
+++ b/mm/page_owner.c
@@ -34,7 +34,7 @@ struct page_owner {
pid_t tgid;
};

-static bool page_owner_enabled = false;
+static bool page_owner_enabled __initdata;
DEFINE_STATIC_KEY_FALSE(page_owner_inited);

static depot_stack_handle_t dummy_handle;
--
2.36.0

2022-05-16 16:03:04

by Muchun Song

Subject: Re: [PATCH] mm/page_owner.c: Add missing __initdata attribute

On Mon, May 16, 2022 at 11:09 AM <[email protected]> wrote:
>
> From: Fanjun Kong <[email protected]>
>
> This patch fix two issues:
> 1. Add __initdata attribute according to include/linux/init.h:
> > For initialized data:
> > You should insert __initdata between the variable name and equal
> > sign followed by value
>
> 2. Fix below error reported by checkpatch.pl:
> ERROR: do not initialise statics to false
>
> Special thanks to Muchun Song :)
>
> Suggested-by: Muchun Song <[email protected]>
> Signed-off-by: Fanjun Kong <[email protected]>

Reviewed-by: Muchun Song <[email protected]>

Thanks.