2020-09-16 18:26:10

by Yue Haibing

Subject: [PATCH net-next] genetlink: Remove unused function genl_err_attr()

It is never used, so can remove it.

Signed-off-by: YueHaibing <[email protected]>
---
include/net/genetlink.h | 8 --------
1 file changed, 8 deletions(-)

diff --git a/include/net/genetlink.h b/include/net/genetlink.h
index 6e5f1e1aa822..b9eb92f3fe86 100644
--- a/include/net/genetlink.h
+++ b/include/net/genetlink.h
@@ -101,14 +101,6 @@ static inline void genl_info_net_set(struct genl_info *info, struct net *net)

#define GENL_SET_ERR_MSG(info, msg) NL_SET_ERR_MSG((info)->extack, msg)

-static inline int genl_err_attr(struct genl_info *info, int err,
- const struct nlattr *attr)
-{
- info->extack->bad_attr = attr;
-
- return err;
-}
-
enum genl_validate_flags {
GENL_DONT_VALIDATE_STRICT = BIT(0),
GENL_DONT_VALIDATE_DUMP = BIT(1),
--
2.17.1

2020-09-17 18:36:35

by Cong Wang

Subject: Re: [PATCH net-next] genetlink: Remove unused function genl_err_attr()

On Wed, Sep 16, 2020 at 9:33 AM YueHaibing <[email protected]> wrote:
>
> It is never used, so can remove it.

This is a bit confusing, it was actually used before, see commit
ab0d76f6823cc3a4e2.

2020-09-17 23:33:09

by David Miller

Subject: Re: [PATCH net-next] genetlink: Remove unused function genl_err_attr()

From: YueHaibing <[email protected]>
Date: Wed, 16 Sep 2020 22:17:28 +0800

> It is never used, so can remove it.
>
> Signed-off-by: YueHaibing <[email protected]>

Applied.

2020-09-18 01:24:19

by Yue Haibing

Subject: Re: [PATCH net-next] genetlink: Remove unused function genl_err_attr()

On 2020/9/18 2:34, Cong Wang wrote:
> On Wed, Sep 16, 2020 at 9:33 AM YueHaibing <[email protected]> wrote:
>>
>> It is never used, so can remove it.
>
> This is a bit confusing, it was actually used before, see commit
> ab0d76f6823cc3a4e2.

Yes,thanks for reminding, will be careful later.
> .
>