2017-06-05 21:38:12

by Patrik Jakobsson

[permalink] [raw]
Subject: Re: [PATCH 0/1] gpu: move include files out of include/linux/i2c

On Mon, May 22, 2017 at 12:11 AM, Wolfram Sang <[email protected]> wrote:
> It doesn't make sense to use include/linux/i2c for client drivers which may in
> fact rather be hwmon or input or whatever devices. As a result, I want to
> deprecate include/linux/i2c for good. This series moves the include files to a
> better location, largely include/linux/platform_data because that is what most
> of the moved include files contain. Please let me know if you think another
> location is more suitable.
>
> I prefer the series to go upstream via the subsystem tree; if you prefer that I
> take it via I2C, just let me know.

I don't think it makes sense to take this through the drm/gma500 since
it's platform data and does not really touch any gma500 specifics.
What makes sense for I2C/platform is probably more important here.

>
> No runtime testing because of no HW, but buildbot is happy with this series at
> least. A branch can be found here:

Not sure anybody have hardware to test mdfld + tc358765. Perhaps some
smartphone exists but I've never seen one.

FWIW, for the small gma500 change you have my:

Acked-by: Patrik Jakobsson <[email protected]>

Cheers

>
> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/platform_data
>
> Thanks and kind regards,
>
> Wolfram
>
>
> Wolfram Sang (1):
> gpu: drm: tc35876x: move header file out of I2C realm
>
> arch/x86/platform/intel-mid/device_libs/platform_tc35876x.c | 2 +-
> drivers/gpu/drm/gma500/tc35876x-dsi-lvds.c | 2 +-
> include/linux/{i2c => platform_data}/tc35876x.h | 0
> 3 files changed, 2 insertions(+), 2 deletions(-)
> rename include/linux/{i2c => platform_data}/tc35876x.h (100%)
>
> --
> 2.11.0
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel


2017-08-13 14:05:19

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH 0/1] gpu: move include files out of include/linux/i2c

On Mon, Jun 05, 2017 at 11:38:08PM +0200, Patrik Jakobsson wrote:
> On Mon, May 22, 2017 at 12:11 AM, Wolfram Sang <[email protected]> wrote:
> > It doesn't make sense to use include/linux/i2c for client drivers which may in
> > fact rather be hwmon or input or whatever devices. As a result, I want to
> > deprecate include/linux/i2c for good. This series moves the include files to a
> > better location, largely include/linux/platform_data because that is what most
> > of the moved include files contain. Please let me know if you think another
> > location is more suitable.
> >
> > I prefer the series to go upstream via the subsystem tree; if you prefer that I
> > take it via I2C, just let me know.
>
> I don't think it makes sense to take this through the drm/gma500 since
> it's platform data and does not really touch any gma500 specifics.
> What makes sense for I2C/platform is probably more important here.

Ok, thank you for the info! I will pick it then.

> > No runtime testing because of no HW, but buildbot is happy with this series at
> > least. A branch can be found here:
>
> Not sure anybody have hardware to test mdfld + tc358765. Perhaps some
> smartphone exists but I've never seen one.

There seems to be an upstream user:

arch/x86/platform/intel-mid/device_libs/platform_tc35876x.c

> FWIW, for the small gma500 change you have my:
>
> Acked-by: Patrik Jakobsson <[email protected]>

Thanks again,

Wolfram


Attachments:
(No filename) (1.42 kB)
signature.asc (833.00 B)
Download all attachments