2022-03-25 15:35:58

by baihaowen

Subject: [PATCH] drm: gma500: clean up some style problems reported by checkpatch.pl

WARNING: Statements should start on a tabstop

WARNING: Missing a blank line after declarations

Signed-off-by: Haowen Bai <[email protected]>
---
drivers/gpu/drm/gma500/mid_bios.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/gma500/mid_bios.c b/drivers/gpu/drm/gma500/mid_bios.c
index 7e76790..71942c2 100644
--- a/drivers/gpu/drm/gma500/mid_bios.c
+++ b/drivers/gpu/drm/gma500/mid_bios.c
@@ -50,8 +50,8 @@ static void mid_get_fuse_settings(struct drm_device *dev)
DRM_INFO("internal display is %s\n",
dev_priv->iLVDS_enable ? "LVDS display" : "MIPI display");

- /* Prevent runtime suspend at start*/
- if (dev_priv->iLVDS_enable) {
+ /* Prevent runtime suspend at start*/
+ if (dev_priv->iLVDS_enable) {
dev_priv->is_lvds_on = true;
dev_priv->is_mipi_on = false;
} else {
@@ -325,6 +325,7 @@ static void mid_get_vbt_data(struct drm_psb_private *dev_priv)
int mid_chip_setup(struct drm_device *dev)
{
struct drm_psb_private *dev_priv = to_drm_psb_private(dev);
+
mid_get_fuse_settings(dev);
mid_get_vbt_data(dev_priv);
mid_get_pci_revID(dev_priv);
--
2.7.4

2022-03-25 19:35:22

by Patrik Jakobsson

Subject: Re: [PATCH] drm: gma500: clean up some style problems reported by checkpatch.pl

On Thu, Mar 24, 2022 at 10:16 AM Haowen Bai <[email protected]> wrote:
>
> WARNING: Statements should start on a tabstop
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Haowen Bai <[email protected]>

Hi, thanks for the patch.

> ---
> drivers/gpu/drm/gma500/mid_bios.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/mid_bios.c b/drivers/gpu/drm/gma500/mid_bios.c
> index 7e76790..71942c2 100644
> --- a/drivers/gpu/drm/gma500/mid_bios.c
> +++ b/drivers/gpu/drm/gma500/mid_bios.c
> @@ -50,8 +50,8 @@ static void mid_get_fuse_settings(struct drm_device *dev)
> DRM_INFO("internal display is %s\n",
> dev_priv->iLVDS_enable ? "LVDS display" : "MIPI display");
>
> - /* Prevent runtime suspend at start*/
> - if (dev_priv->iLVDS_enable) {
> + /* Prevent runtime suspend at start*/

There should also be a space between "start" and "*/" at the end of the line

-Patrik

> + if (dev_priv->iLVDS_enable) {
> dev_priv->is_lvds_on = true;
> dev_priv->is_mipi_on = false;
> } else {
> @@ -325,6 +325,7 @@ static void mid_get_vbt_data(struct drm_psb_private *dev_priv)
> int mid_chip_setup(struct drm_device *dev)
> {
> struct drm_psb_private *dev_priv = to_drm_psb_private(dev);
> +
> mid_get_fuse_settings(dev);
> mid_get_vbt_data(dev_priv);
> mid_get_pci_revID(dev_priv);
> --
> 2.7.4
>