2022-05-06 07:48:04

by Jiapeng Chong

Subject: [PATCH] drm/gma500: Clean up some inconsistent indenting

Eliminate the follow smatch warning:

drivers/gpu/drm/gma500/cdv_device.c:250 cdv_errata() warn:
inconsistent indenting.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/gpu/drm/gma500/cdv_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/gma500/cdv_device.c b/drivers/gpu/drm/gma500/cdv_device.c
index dd32b484dd82..09684c42cbf6 100644
--- a/drivers/gpu/drm/gma500/cdv_device.c
+++ b/drivers/gpu/drm/gma500/cdv_device.c
@@ -247,7 +247,7 @@ static void cdv_errata(struct drm_device *dev)
* Bonus Launch to work around the issue, by degrading
* performance.
*/
- CDV_MSG_WRITE32(pci_domain_nr(pdev->bus), 3, 0x30, 0x08027108);
+ CDV_MSG_WRITE32(pci_domain_nr(pdev->bus), 3, 0x30, 0x08027108);
}

/**
--
2.20.1.7.g153144c

2022-06-02 19:21:45

by Patrik Jakobsson

Subject: Re: [PATCH] drm/gma500: Clean up some inconsistent indenting

On Thu, May 5, 2022 at 10:10 AM Jiapeng Chong
<[email protected]> wrote:
>
> Eliminate the follow smatch warning:
>
> drivers/gpu/drm/gma500/cdv_device.c:250 cdv_errata() warn:
> inconsistent indenting.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

Hi Jiapeng,
One entire patch to remove a single whitespace seems a bit excessive.
Would you mind fixing a few more of the code style issues in
cdv_device.c while you're at it?

Checkpatch can give you a few hints:
./scripts/checkpatch.pl -f drivers/gpu/drm/gma500/cdv_device.c

Thanks
Patrik

> ---
> drivers/gpu/drm/gma500/cdv_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/gma500/cdv_device.c b/drivers/gpu/drm/gma500/cdv_device.c
> index dd32b484dd82..09684c42cbf6 100644
> --- a/drivers/gpu/drm/gma500/cdv_device.c
> +++ b/drivers/gpu/drm/gma500/cdv_device.c
> @@ -247,7 +247,7 @@ static void cdv_errata(struct drm_device *dev)
> * Bonus Launch to work around the issue, by degrading
> * performance.
> */
> - CDV_MSG_WRITE32(pci_domain_nr(pdev->bus), 3, 0x30, 0x08027108);
> + CDV_MSG_WRITE32(pci_domain_nr(pdev->bus), 3, 0x30, 0x08027108);
> }
>
> /**
> --
> 2.20.1.7.g153144c
>