2024-04-30 15:41:45

by Kairui Song

[permalink] [raw]
Subject: Re: [EXTERNAL] [PATCH v3 05/12] cifs: drop usage of page_file_offset

On Tue, Apr 30, 2024 at 4:19 AM Steven French
<[email protected]> wrote:
>
> Wouldn't this make it harder to fix the regression when swap file support was temporarily removed from cifs.ko (due to the folio migration)? I was hoping to come back to fixing swapfile support for cifs.ko in 6.10-rc (which used to pass the various xfstests for this but code got removed with folios/netfs changes).
>

Hi Steven,

I think this won't cause any trouble for that, the new swap_rw
interface should have splitted the swap cache from fs side, which made
the code struct cleaner, and I think that's the right path. NFS is
using that already. With this interface, .read_folio (cifs_read_folio)
should never be called for swap cache folios.