2021-07-25 02:15:04

by Zheyu Ma

Subject: [PATCH 0/3] add checks against divide error

Zheyu Ma (3):
video: fbdev: kyro: add a check against divide error
video: fbdev: riva: add a check against divide error
video: fbdev: asiliantfb: add a check against divide error

drivers/video/fbdev/asiliantfb.c | 3 +++
drivers/video/fbdev/kyro/fbdev.c | 3 +++
drivers/video/fbdev/riva/fbdev.c | 3 +++
3 files changed, 9 insertions(+)

--
2.17.6

2021-07-26 09:44:31

by Zheyu Ma

Subject: Re: [PATCH 0/3] add checks against divide error

On Mon, Jul 26, 2021 at 4:18 AM Sam Ravnborg <[email protected]> wrote:
>
> Hi Zheyu,
>
> On Sun, Jul 25, 2021 at 02:10:51AM +0000, Zheyu Ma wrote:
> > Zheyu Ma (3):
> > video: fbdev: kyro: add a check against divide error
> > video: fbdev: riva: add a check against divide error
> > video: fbdev: asiliantfb: add a check against divide error
>
> I would prefer something a bit more descriptive - like:
>
> video: fbdev: <driver>: Error out if pixclk equals zero
>
> Please respin so we have something like the above.
> I looked briefly at the patches, they looked fine.

Thanks for your valuable comments, I will re-edit the commit log and
send the patches.

Regards,
Zheyu Ma