Convert the ralink-usb-phy bindings to DT schema.
Signed-off-by: Sergio Paracuellos <[email protected]>
---
Changes in v3:
- Address Krzysztof review comments:
+ Use compatible to match yaml file name.
+ Reorder compatible alphabetically.
+ Add missing blank line betwwen compatible and reg properties.
+ Move allOf block after required block and add missing else case there.
Changes in v2:
- Add missing SPDX License Identifier
.../bindings/phy/mediatek,mt7628-usbphy.yaml | 74 +++++++++++++++++++
.../bindings/phy/ralink-usb-phy.txt | 23 ------
2 files changed, 74 insertions(+), 23 deletions(-)
create mode 100644 Documentation/devicetree/bindings/phy/mediatek,mt7628-usbphy.yaml
delete mode 100644 Documentation/devicetree/bindings/phy/ralink-usb-phy.txt
diff --git a/Documentation/devicetree/bindings/phy/mediatek,mt7628-usbphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,mt7628-usbphy.yaml
new file mode 100644
index 000000000000..ce2c228e3216
--- /dev/null
+++ b/Documentation/devicetree/bindings/phy/mediatek,mt7628-usbphy.yaml
@@ -0,0 +1,74 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/phy/mediatek,mt7628-usbphy.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Mediatek/Ralink USB PHY
+
+maintainers:
+ - Sergio Paracuellos <[email protected]>
+
+properties:
+ compatible:
+ enum:
+ - mediatek,mt7620-usbphy
+ - mediatek,mt7628-usbphy
+ - ralink,rt3352-usbphy
+
+ reg:
+ maxItems: 1
+
+ "#phy-cells":
+ const: 0
+
+ ralink,sysctl:
+ description:
+ phandle to a ralink syscon register region.
+ $ref: /schemas/types.yaml#/definitions/phandle
+
+ resets:
+ items:
+ - description: USB Host reset controller
+ - description: USB Device reset controller
+
+ reset-names:
+ items:
+ - const: host
+ - const: device
+
+required:
+ - compatible
+ - "#phy-cells"
+ - ralink,sysctl
+ - resets
+ - reset-names
+
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: mediatek,mt7628-usbphy
+ then:
+ required:
+ - reg
+ else:
+ properties:
+ reg: false
+
+additionalProperties: false
+
+examples:
+ - |
+ phy@10120000 {
+ compatible = "mediatek,mt7628-usbphy";
+ reg = <0x10120000 0x1000>;
+ #phy-cells = <0>;
+ ralink,sysctl = <&sysc>;
+ resets = <&rstctrl 22>,
+ <&rstctrl 25>;
+ reset-names = "host", "device";
+ };
+
+...
diff --git a/Documentation/devicetree/bindings/phy/ralink-usb-phy.txt b/Documentation/devicetree/bindings/phy/ralink-usb-phy.txt
deleted file mode 100644
index 9d2868a437ab..000000000000
--- a/Documentation/devicetree/bindings/phy/ralink-usb-phy.txt
+++ /dev/null
@@ -1,23 +0,0 @@
-Mediatek/Ralink USB PHY
-
-Required properties:
- - compatible: "ralink,rt3352-usbphy"
- "mediatek,mt7620-usbphy"
- "mediatek,mt7628-usbphy"
- - reg: required for "mediatek,mt7628-usbphy", unused otherwise
- - #phy-cells: should be 0
- - ralink,sysctl: a phandle to a ralink syscon register region
- - resets: the two reset controllers for host and device
- - reset-names: the names of the 2 reset controllers
-
-Example:
-
-usbphy: phy {
- compatible = "mediatek,mt7628-usbphy";
- reg = <0x10120000 0x1000>;
- #phy-cells = <0>;
-
- ralink,sysctl = <&sysc>;
- resets = <&rstctrl 22 &rstctrl 25>;
- reset-names = "host", "device";
-};
--
2.25.1
On 22/10/2023 18:30, Sergio Paracuellos wrote:
> Convert the ralink-usb-phy bindings to DT schema.
>
> Signed-off-by: Sergio Paracuellos <[email protected]>
> ---
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On Sun, Oct 22, 2023 at 6:37 PM Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 22/10/2023 18:30, Sergio Paracuellos wrote:
> > Convert the ralink-usb-phy bindings to DT schema.
> >
> > Signed-off-by: Sergio Paracuellos <[email protected]>
> > ---
>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
>
> Best regards,
> Krzysztof
Thanks, Krzysztof!
On Sun, 22 Oct 2023 18:30:06 +0200, Sergio Paracuellos wrote:
> Convert the ralink-usb-phy bindings to DT schema.
>
>
Applied, thanks!
[1/1] dt-bindings: phy: ralink-usb-phy: convert to dtschema
commit: f5d5a0b5553aa1a4e165e6fc6c582db487768846
Best regards,
--
~Vinod