2021-09-26 15:01:20

by Sergio Paracuellos

[permalink] [raw]
Subject: [PATCH 0/3] staging: mt7621-dts: complete reset missing stuff

Hi all,

Mt7621 SoC uses reset controller from ralink rt2880.

In order to get 'mt7621.dtsi' file out of staging there are still
some nodes which are not documented at all. This patch series
add documentation for reset controller in ralink rt2880 derived
SoCs which corresponds with 'ralink,rt2880-reset' compatible.

It also align new binding documentation using defined reset bits
along the device tree file itself.

Thanks in advance for your time.

Best regards,
Sergio Paracuellos

Sergio Paracuellos (3):
dt-bindings: reset: add dt binding header for ralink RT2880 resets
dt: bindings: add ralink RT2880 resets device tree binding
documentation
staging: mt7621-dts: align resets with binding documentation

.../bindings/reset/ralink,rt2880-reset.yaml | 39 ++++++++++++++++++
drivers/staging/mt7621-dts/mt7621.dtsi | 23 ++++++-----
include/dt-bindings/reset/ralink-rt2880.h | 40 +++++++++++++++++++
3 files changed, 91 insertions(+), 11 deletions(-)
create mode 100644 Documentation/devicetree/bindings/reset/ralink,rt2880-reset.yaml
create mode 100644 include/dt-bindings/reset/ralink-rt2880.h

--
2.25.1


2021-09-26 15:01:21

by Sergio Paracuellos

[permalink] [raw]
Subject: [PATCH 1/3] dt-bindings: reset: add dt binding header for ralink RT2880 resets

Adds dt binding header for 'ralink,rt2880-reset' resets.

Signed-off-by: Sergio Paracuellos <[email protected]>
---
include/dt-bindings/reset/ralink-rt2880.h | 40 +++++++++++++++++++++++
1 file changed, 40 insertions(+)
create mode 100644 include/dt-bindings/reset/ralink-rt2880.h

diff --git a/include/dt-bindings/reset/ralink-rt2880.h b/include/dt-bindings/reset/ralink-rt2880.h
new file mode 100644
index 000000000000..266ef521a584
--- /dev/null
+++ b/include/dt-bindings/reset/ralink-rt2880.h
@@ -0,0 +1,40 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2021 Sergio Paracuellos
+ * Author: Sergio Paracuellos <[email protected]>
+ */
+
+#ifndef DT_BINDING_RALINK_RT2880_RESET_H
+#define DT_BINDING_RALINK_RT2880_RESET_H
+
+/*
+ * Ralink RT2880 SoC reset controller register bits.
+ */
+#define RALINK_RT2880_SYS 0
+#define RALINK_RT2880_MCM 2
+#define RALINK_RT2880_HSDMA 5
+#define RALINK_RT2880_FE 6
+#define RALINK_RT2880_SPDIFTX 7
+#define RALINK_RT2880_TIMER 8
+#define RALINK_RT2880_INT 9
+#define RALINK_RT2880_MC 10
+#define RALINK_RT2880_PCM 11
+#define RALINK_RT2880_PIO 13
+#define RALINK_RT2880_GDMA 14
+#define RALINK_RT2880_NFI 15
+#define RALINK_RT2880_I2C 16
+#define RALINK_RT2880_I2S 17
+#define RALINK_RT2880_SPI 18
+#define RALINK_RT2880_UART1 19
+#define RALINK_RT2880_UART2 20
+#define RALINK_RT2880_UART3 21
+#define RALINK_RT2880_ETH 23
+#define RALINK_RT2880_PCIE0 24
+#define RALINK_RT2880_PCIE1 25
+#define RALINK_RT2880_PCIE2 26
+#define RALINK_RT2880_AUX_STCK 28
+#define RALINK_RT2880_CRYPTO 29
+#define RALINK_RT2880_SDXC 30
+#define RALINK_RT2880_PPE 31
+
+#endif /* DT_BINDING_RALINK_RT2880_RESET_H */
--
2.25.1

2021-10-04 23:26:04

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 1/3] dt-bindings: reset: add dt binding header for ralink RT2880 resets

On Sun, Sep 26, 2021 at 04:59:29PM +0200, Sergio Paracuellos wrote:
> Adds dt binding header for 'ralink,rt2880-reset' resets.
>
> Signed-off-by: Sergio Paracuellos <[email protected]>
> ---
> include/dt-bindings/reset/ralink-rt2880.h | 40 +++++++++++++++++++++++
> 1 file changed, 40 insertions(+)
> create mode 100644 include/dt-bindings/reset/ralink-rt2880.h
>
> diff --git a/include/dt-bindings/reset/ralink-rt2880.h b/include/dt-bindings/reset/ralink-rt2880.h
> new file mode 100644
> index 000000000000..266ef521a584
> --- /dev/null
> +++ b/include/dt-bindings/reset/ralink-rt2880.h
> @@ -0,0 +1,40 @@
> +/* SPDX-License-Identifier: GPL-2.0 */

Dual license please.

2021-10-04 23:28:34

by Sergio Paracuellos

[permalink] [raw]
Subject: Re: [PATCH 1/3] dt-bindings: reset: add dt binding header for ralink RT2880 resets

On Mon, Oct 4, 2021 at 8:02 PM Rob Herring <[email protected]> wrote:
>
> On Sun, Sep 26, 2021 at 04:59:29PM +0200, Sergio Paracuellos wrote:
> > Adds dt binding header for 'ralink,rt2880-reset' resets.
> >
> > Signed-off-by: Sergio Paracuellos <[email protected]>
> > ---
> > include/dt-bindings/reset/ralink-rt2880.h | 40 +++++++++++++++++++++++
> > 1 file changed, 40 insertions(+)
> > create mode 100644 include/dt-bindings/reset/ralink-rt2880.h
> >
> > diff --git a/include/dt-bindings/reset/ralink-rt2880.h b/include/dt-bindings/reset/ralink-rt2880.h
> > new file mode 100644
> > index 000000000000..266ef521a584
> > --- /dev/null
> > +++ b/include/dt-bindings/reset/ralink-rt2880.h
> > @@ -0,0 +1,40 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
>
> Dual license please.

Ah, ok. I thought the dual license was only for binding yaml files but
not for headers since there are a lot of already mainlined files with
only GPL-2.0. I will take into account from now that binding headers
also need dual license.

Thanks for the review and clarification.

Best regards,
Sergio Paracuellos

2021-10-05 13:34:11

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 1/3] dt-bindings: reset: add dt binding header for ralink RT2880 resets

On Mon, Oct 4, 2021 at 1:26 PM Sergio Paracuellos
<[email protected]> wrote:
>
> On Mon, Oct 4, 2021 at 8:02 PM Rob Herring <[email protected]> wrote:
> >
> > On Sun, Sep 26, 2021 at 04:59:29PM +0200, Sergio Paracuellos wrote:
> > > Adds dt binding header for 'ralink,rt2880-reset' resets.
> > >
> > > Signed-off-by: Sergio Paracuellos <[email protected]>
> > > ---
> > > include/dt-bindings/reset/ralink-rt2880.h | 40 +++++++++++++++++++++++
> > > 1 file changed, 40 insertions(+)
> > > create mode 100644 include/dt-bindings/reset/ralink-rt2880.h
> > >
> > > diff --git a/include/dt-bindings/reset/ralink-rt2880.h b/include/dt-bindings/reset/ralink-rt2880.h
> > > new file mode 100644
> > > index 000000000000..266ef521a584
> > > --- /dev/null
> > > +++ b/include/dt-bindings/reset/ralink-rt2880.h
> > > @@ -0,0 +1,40 @@
> > > +/* SPDX-License-Identifier: GPL-2.0 */
> >
> > Dual license please.
>
> Ah, ok. I thought the dual license was only for binding yaml files but
> not for headers since there are a lot of already mainlined files with
> only GPL-2.0. I will take into account from now that binding headers
> also need dual license.

If you want your dts files used by other projects such as *BSD, then
they and their include files need to be licensed for that.

Rob

2021-10-05 14:30:44

by Sergio Paracuellos

[permalink] [raw]
Subject: Re: [PATCH 1/3] dt-bindings: reset: add dt binding header for ralink RT2880 resets

On Tue, Oct 5, 2021 at 3:29 PM Rob Herring <[email protected]> wrote:
>
> On Mon, Oct 4, 2021 at 1:26 PM Sergio Paracuellos
> <[email protected]> wrote:
> >
> > On Mon, Oct 4, 2021 at 8:02 PM Rob Herring <[email protected]> wrote:
> > >
> > > On Sun, Sep 26, 2021 at 04:59:29PM +0200, Sergio Paracuellos wrote:
> > > > Adds dt binding header for 'ralink,rt2880-reset' resets.
> > > >
> > > > Signed-off-by: Sergio Paracuellos <[email protected]>
> > > > ---
> > > > include/dt-bindings/reset/ralink-rt2880.h | 40 +++++++++++++++++++++++
> > > > 1 file changed, 40 insertions(+)
> > > > create mode 100644 include/dt-bindings/reset/ralink-rt2880.h
> > > >
> > > > diff --git a/include/dt-bindings/reset/ralink-rt2880.h b/include/dt-bindings/reset/ralink-rt2880.h
> > > > new file mode 100644
> > > > index 000000000000..266ef521a584
> > > > --- /dev/null
> > > > +++ b/include/dt-bindings/reset/ralink-rt2880.h
> > > > @@ -0,0 +1,40 @@
> > > > +/* SPDX-License-Identifier: GPL-2.0 */
> > >
> > > Dual license please.
> >
> > Ah, ok. I thought the dual license was only for binding yaml files but
> > not for headers since there are a lot of already mainlined files with
> > only GPL-2.0. I will take into account from now that binding headers
> > also need dual license.
>
> If you want your dts files used by other projects such as *BSD, then
> they and their include files need to be licensed for that.

Ok, it is clear now. Thanks for clarification.

Best regards,
Sergio Paracuellos
>
> Rob