2022-11-28 22:10:02

by Arınç ÜNAL

Subject: [PATCH] mips: ralink: mt7621: fix phy-mode of external phy on GB-PC2

The phy-mode property must be defined on the MAC instead of the PHY. Define
phy-mode under gmac1 which the external phy is connected to.

Tested-by: Petr Louda <[email protected]>
Signed-off-by: Arınç ÜNAL <[email protected]>
---
arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts b/arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts
index 7515555388ae..e31417569e09 100644
--- a/arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts
+++ b/arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts
@@ -113,13 +113,13 @@ &pcie {

&gmac1 {
status = "okay";
+ phy-mode = "rgmii-rxid";
phy-handle = <&ethphy5>;
};

&mdio {
ethphy5: ethernet-phy@5 {
reg = <5>;
- phy-mode = "rgmii-rxid";
};
};

--
2.34.1

2022-11-29 04:56:11

by Sergio Paracuellos

Subject: Re: [PATCH] mips: ralink: mt7621: fix phy-mode of external phy on GB-PC2

On Mon, Nov 28, 2022 at 10:33 PM Arınç ÜNAL <[email protected]> wrote:
>
> The phy-mode property must be defined on the MAC instead of the PHY. Define
> phy-mode under gmac1 which the external phy is connected to.
>
> Tested-by: Petr Louda <[email protected]>
> Signed-off-by: Arınç ÜNAL <[email protected]>
> ---
> arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Sergio Paracuellos <[email protected]>

Thanks,
Sergio Paracuellos

2022-12-01 11:51:19

by Thomas Bogendoerfer

Subject: Re: [PATCH] mips: ralink: mt7621: fix phy-mode of external phy on GB-PC2

On Tue, Nov 29, 2022 at 12:32:38AM +0300, Arınç ÜNAL wrote:
> The phy-mode property must be defined on the MAC instead of the PHY. Define
> phy-mode under gmac1 which the external phy is connected to.
>
> Tested-by: Petr Louda <[email protected]>
> Signed-off-by: Arınç ÜNAL <[email protected]>
> ---
> arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]

2023-01-15 09:28:53

by Arınç ÜNAL

Subject: Re: [PATCH] mips: ralink: mt7621: fix phy-mode of external phy on GB-PC2

On 1.12.2022 13:50, Thomas Bogendoerfer wrote:
> On Tue, Nov 29, 2022 at 12:32:38AM +0300, Arınç ÜNAL wrote:
>> The phy-mode property must be defined on the MAC instead of the PHY. Define
>> phy-mode under gmac1 which the external phy is connected to.
>>
>> Tested-by: Petr Louda <[email protected]>
>> Signed-off-by: Arınç ÜNAL <[email protected]>
>> ---
>> arch/mips/boot/dts/ralink/mt7621-gnubee-gb-pc2.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> applied to mips-next.

I just realised I forgot to add "dts:" to the patch subject. Would that
be a problem?

Arınç