2013-03-12 23:53:51

by Fabio Estevam

Subject: [PATCH] dma: ipu: ipu_idmac: Fix section mismatch

From: Fabio Estevam <[email protected]>

Since commit 84c1e63c12 (dma: Remove erroneous __exit and __exit_p() references)
the following section mismatch happens:

WARNING: drivers/built-in.o(.text+0x20f94): Section mismatch in reference from the function ipu_remove() to the function .exit.text:ipu_idmac_exit()
The function ipu_remove() references a function in an exit section.
Often the function ipu_idmac_exit() has valid usage outside the exit section
and the fix is to remove the __exit annotation of ipu_idmac_exit.

Remove the '__exit' annotation from ipu_idmac_exit in order to fix it.

Signed-off-by: Fabio Estevam <[email protected]>
---
drivers/dma/ipu/ipu_idmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c
index d6d5d7e..d39c2cd 100644
--- a/drivers/dma/ipu/ipu_idmac.c
+++ b/drivers/dma/ipu/ipu_idmac.c
@@ -1642,7 +1642,7 @@ static int __init ipu_idmac_init(struct ipu *ipu)
return dma_async_device_register(&idmac->dma);
}

-static void __exit ipu_idmac_exit(struct ipu *ipu)
+static void ipu_idmac_exit(struct ipu *ipu)
{
int i;
struct idmac *idmac = &ipu->idmac;
--
1.7.9.5

2013-03-14 00:40:04

by Maxin B. John

Subject: Re: [PATCH] dma: ipu: ipu_idmac: Fix section mismatch

On Wed, Mar 13, 2013 at 1:53 AM, Fabio Estevam <[email protected]> wrote:
> From: Fabio Estevam <[email protected]>
>
> Since commit 84c1e63c12 (dma: Remove erroneous __exit and __exit_p() references)
> the following section mismatch happens:
>
> WARNING: drivers/built-in.o(.text+0x20f94): Section mismatch in reference from the function ipu_remove() to the function .exit.text:ipu_idmac_exit()
> The function ipu_remove() references a function in an exit section.
> Often the function ipu_idmac_exit() has valid usage outside the exit section
> and the fix is to remove the __exit annotation of ipu_idmac_exit.
>
> Remove the '__exit' annotation from ipu_idmac_exit in order to fix it.

Good catch...
Acked-by: Maxin B. John <[email protected]>

> Signed-off-by: Fabio Estevam <[email protected]>
> ---
> drivers/dma/ipu/ipu_idmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c
> index d6d5d7e..d39c2cd 100644
> --- a/drivers/dma/ipu/ipu_idmac.c
> +++ b/drivers/dma/ipu/ipu_idmac.c
> @@ -1642,7 +1642,7 @@ static int __init ipu_idmac_init(struct ipu *ipu)
> return dma_async_device_register(&idmac->dma);
> }
>
> -static void __exit ipu_idmac_exit(struct ipu *ipu)
> +static void ipu_idmac_exit(struct ipu *ipu)
> {
> int i;
> struct idmac *idmac = &ipu->idmac;
> --
> 1.7.9.5
>
> --

Warm Regards,
Maxin

2013-03-20 05:17:26

by Fabio Estevam

Subject: Re: [PATCH] dma: ipu: ipu_idmac: Fix section mismatch

Hi Vinod,

On Wed, Mar 13, 2013 at 9:39 PM, Maxin B. John <[email protected]> wrote:
> On Wed, Mar 13, 2013 at 1:53 AM, Fabio Estevam <[email protected]> wrote:
>> From: Fabio Estevam <[email protected]>
>>
>> Since commit 84c1e63c12 (dma: Remove erroneous __exit and __exit_p() references)
>> the following section mismatch happens:
>>
>> WARNING: drivers/built-in.o(.text+0x20f94): Section mismatch in reference from the function ipu_remove() to the function .exit.text:ipu_idmac_exit()
>> The function ipu_remove() references a function in an exit section.
>> Often the function ipu_idmac_exit() has valid usage outside the exit section
>> and the fix is to remove the __exit annotation of ipu_idmac_exit.
>>
>> Remove the '__exit' annotation from ipu_idmac_exit in order to fix it.
>
> Good catch...
> Acked-by: Maxin B. John <[email protected]>

Can this one be applied?

2013-03-21 08:49:14

by Vinod Koul

Subject: Re: [PATCH] dma: ipu: ipu_idmac: Fix section mismatch

On Tue, Mar 12, 2013 at 08:53:37PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <[email protected]>
>
> Since commit 84c1e63c12 (dma: Remove erroneous __exit and __exit_p() references)
> the following section mismatch happens:
>
> WARNING: drivers/built-in.o(.text+0x20f94): Section mismatch in reference from the function ipu_remove() to the function .exit.text:ipu_idmac_exit()
> The function ipu_remove() references a function in an exit section.
> Often the function ipu_idmac_exit() has valid usage outside the exit section
> and the fix is to remove the __exit annotation of ipu_idmac_exit.
>
> Remove the '__exit' annotation from ipu_idmac_exit in order to fix it.
>
> Signed-off-by: Fabio Estevam <[email protected]>
Applied Thanks

--
~Vinod
> ---
> drivers/dma/ipu/ipu_idmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c
> index d6d5d7e..d39c2cd 100644
> --- a/drivers/dma/ipu/ipu_idmac.c
> +++ b/drivers/dma/ipu/ipu_idmac.c
> @@ -1642,7 +1642,7 @@ static int __init ipu_idmac_init(struct ipu *ipu)
> return dma_async_device_register(&idmac->dma);
> }
>
> -static void __exit ipu_idmac_exit(struct ipu *ipu)
> +static void ipu_idmac_exit(struct ipu *ipu)
> {
> int i;
> struct idmac *idmac = &ipu->idmac;
> --
> 1.7.9.5
>