2012-10-14 15:44:58

by Huang Shijie

[permalink] [raw]

Subject: [PATCH] mtd: use the NAND_STATUS_FAIL to replace the hardcode

---

Use the NAND_STATUS_FAIL to replace the hardcode "0x01",
which make the code more readable.

Signed-off-by: Huang Shijie <[email protected]>
---
drivers/mtd/nand/nand_base.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index d5ece6e..4569174 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -899,7 +899,7 @@ static int __nand_unlock(struct mtd_info *mtd, loff_t ofs,
/* Call wait ready function */
status = chip->waitfunc(mtd, chip);
/* See if device thinks it succeeded */
- if (status & 0x01) {
+ if (status & NAND_STATUS_FAIL) {
pr_debug("%s: error status = 0x%08x\n",
__func__, status);
ret = -EIO;
@@ -1004,7 +1004,7 @@ int nand_lock(struct mtd_info *mtd, loff_t ofs, uint64_t len)
/* Call wait ready function */
status = chip->waitfunc(mtd, chip);
/* See if device thinks it succeeded */
- if (status & 0x01) {
+ if (status & NAND_STATUS_FAIL) {
pr_debug("%s: error status = 0x%08x\n",
__func__, status);
ret = -EIO;
--
1.7.4.4

2012-10-24 06:14:23

by Huang Shijie

[permalink] [raw]

Subject: Re: [PATCH] mtd: use the NAND_STATUS_FAIL to replace the hardcode

---

ping

On Mon, Oct 15, 2012 at 11:47 AM, Huang Shijie <[email protected]> wrote:
> Use the NAND_STATUS_FAIL to replace the hardcode "0x01",
> which make the code more readable.
>
> Signed-off-by: Huang Shijie <[email protected]>
> ---
> drivers/mtd/nand/nand_base.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index d5ece6e..4569174 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -899,7 +899,7 @@ static int __nand_unlock(struct mtd_info *mtd, loff_t ofs,
> /* Call wait ready function */
> status = chip->waitfunc(mtd, chip);
> /* See if device thinks it succeeded */
> - if (status & 0x01) {
> + if (status & NAND_STATUS_FAIL) {
> pr_debug("%s: error status = 0x%08x\n",
> __func__, status);
> ret = -EIO;
> @@ -1004,7 +1004,7 @@ int nand_lock(struct mtd_info *mtd, loff_t ofs, uint64_t len)
> /* Call wait ready function */
> status = chip->waitfunc(mtd, chip);
> /* See if device thinks it succeeded */
> - if (status & 0x01) {
> + if (status & NAND_STATUS_FAIL) {
> pr_debug("%s: error status = 0x%08x\n",
> __func__, status);
> ret = -EIO;
> --
> 1.7.4.4
>

2012-10-25 16:07:06

by Brian Norris

[permalink] [raw]

Subject: Re: [PATCH] mtd: use the NAND_STATUS_FAIL to replace the hardcode

---

FWIW

On Sun, Oct 14, 2012 at 8:47 PM, Huang Shijie <[email protected]> wrote:
> Use the NAND_STATUS_FAIL to replace the hardcode "0x01",
> which make the code more readable.
>
> Signed-off-by: Huang Shijie <[email protected]>

Acked-by: Brian Norris <[email protected]>

2012-10-26 14:21:46

by Artem Bityutskiy

[permalink] [raw]

Subject: Re: [PATCH] mtd: use the NAND_STATUS_FAIL to replace the hardcode

---

On Sun, 2012-10-14 at 23:47 -0400, Huang Shijie wrote:
> Use the NAND_STATUS_FAIL to replace the hardcode "0x01",
> which make the code more readable.
>
> Signed-off-by: Huang Shijie <[email protected]>

Pushed to l2-mtd.git, thanks!

--
Best Regards,
Artem Bityutskiy

---

Attachments:

signature.asc (836.00 B)
This is a digitally signed message part