2024-01-23 02:11:22

by Kees Cook

Subject: [PATCH] ARM: fault: Add "cut here" line for prefetch aborts

The common pattern in arm is to emit a "8<--- cut here ---" line for
faults, but it was missing for do_PrefetchAbort(). Add it.

Cc: "Russell King (Oracle)" <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Wang Kefeng <[email protected]>
Cc: Ben Hutchings <[email protected]>
Cc: [email protected]
Signed-off-by: Kees Cook <[email protected]>
---
arch/arm/mm/fault.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/mm/fault.c b/arch/arm/mm/fault.c
index e96fb40b9cc3..e804432e905e 100644
--- a/arch/arm/mm/fault.c
+++ b/arch/arm/mm/fault.c
@@ -586,6 +586,7 @@ do_PrefetchAbort(unsigned long addr, unsigned int ifsr, struct pt_regs *regs)
if (!inf->fn(addr, ifsr | FSR_LNX_PF, regs))
return;

+ pr_alert("8<--- cut here ---\n");
pr_alert("Unhandled prefetch abort: %s (0x%03x) at 0x%08lx\n",
inf->name, ifsr, addr);

--
2.34.1

2024-01-23 13:47:32

by Ard Biesheuvel

Subject: Re: [PATCH] ARM: fault: Add "cut here" line for prefetch aborts

On Tue, 23 Jan 2024 at 02:12, Kees Cook <[email protected]> wrote:
>
> The common pattern in arm is to emit a "8<--- cut here ---" line for
> faults, but it was missing for do_PrefetchAbort(). Add it.
>
> Cc: "Russell King (Oracle)" <[email protected]>
> Cc: Ard Biesheuvel <[email protected]>
> Cc: Wang Kefeng <[email protected]>
> Cc: Ben Hutchings <[email protected]>
> Cc: [email protected]
> Signed-off-by: Kees Cook <[email protected]>

Acked-by: Ard Biesheuvel <[email protected]>

> ---
> arch/arm/mm/fault.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mm/fault.c b/arch/arm/mm/fault.c
> index e96fb40b9cc3..e804432e905e 100644
> --- a/arch/arm/mm/fault.c
> +++ b/arch/arm/mm/fault.c
> @@ -586,6 +586,7 @@ do_PrefetchAbort(unsigned long addr, unsigned int ifsr, struct pt_regs *regs)
> if (!inf->fn(addr, ifsr | FSR_LNX_PF, regs))
> return;
>
> + pr_alert("8<--- cut here ---\n");
> pr_alert("Unhandled prefetch abort: %s (0x%03x) at 0x%08lx\n",
> inf->name, ifsr, addr);
>
> --
> 2.34.1
>