2022-10-06 23:27:10

by Kees Cook

[permalink] [raw]
Subject: Re: [PATCH 7/8] efi: pstore: Follow convention for the efi-pstore backend name

On Thu, Oct 06, 2022 at 07:42:11PM -0300, Guilherme G. Piccoli wrote:
> For some reason, the efi-pstore backend name (exposed through the
> pstore infrastructure) is hardcoded as "efi", whereas all the other
> backends follow a kind of convention in using the module name.
>
> Let's do it here as well, to make user's life easier (they might
> use this info for unloading the module backend, for example).
>
> Cc: Ard Biesheuvel <[email protected]>
> Signed-off-by: Guilherme G. Piccoli <[email protected]>

Looks fine to me. Ard, if you don't object, I can carry this in the
pstore tree.

--
Kees Cook


2022-10-07 08:54:09

by Ard Biesheuvel

[permalink] [raw]
Subject: Re: [PATCH 7/8] efi: pstore: Follow convention for the efi-pstore backend name

On Fri, 7 Oct 2022 at 01:16, Kees Cook <[email protected]> wrote:
>
> On Thu, Oct 06, 2022 at 07:42:11PM -0300, Guilherme G. Piccoli wrote:
> > For some reason, the efi-pstore backend name (exposed through the
> > pstore infrastructure) is hardcoded as "efi", whereas all the other
> > backends follow a kind of convention in using the module name.
> >
> > Let's do it here as well, to make user's life easier (they might
> > use this info for unloading the module backend, for example).
> >
> > Cc: Ard Biesheuvel <[email protected]>
> > Signed-off-by: Guilherme G. Piccoli <[email protected]>
>
> Looks fine to me. Ard, if you don't object, I can carry this in the
> pstore tree.
>

Acked-by: Ard Biesheuvel <[email protected]>