s/Hisilicon/HiSilicon/g.
It should use capital S, according to
https://www.hisilicon.com/en/terms-of-use.
Signed-off-by: Hao Fang <[email protected]>
---
drivers/mmc/host/dw_mmc-k3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/dw_mmc-k3.c b/drivers/mmc/host/dw_mmc-k3.c
index 29d2494..0311a37 100644
--- a/drivers/mmc/host/dw_mmc-k3.c
+++ b/drivers/mmc/host/dw_mmc-k3.c
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0-or-later
/*
* Copyright (c) 2013 Linaro Ltd.
- * Copyright (c) 2013 Hisilicon Limited.
+ * Copyright (c) 2013 HiSilicon Limited.
*/
#include <linux/bitops.h>
--
2.8.1
On Tue, 30 Mar 2021 at 08:43, Hao Fang <[email protected]> wrote:
>
> s/Hisilicon/HiSilicon/g.
> It should use capital S, according to
> https://www.hisilicon.com/en/terms-of-use.
>
> Signed-off-by: Hao Fang <[email protected]>
> ---
> drivers/mmc/host/dw_mmc-k3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-k3.c b/drivers/mmc/host/dw_mmc-k3.c
> index 29d2494..0311a37 100644
> --- a/drivers/mmc/host/dw_mmc-k3.c
> +++ b/drivers/mmc/host/dw_mmc-k3.c
> @@ -1,7 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
> /*
> * Copyright (c) 2013 Linaro Ltd.
> - * Copyright (c) 2013 Hisilicon Limited.
> + * Copyright (c) 2013 HiSilicon Limited.
This change looks really silly to me, but I am not a lawyer - so I
can't tell if this makes sense or not.
In any case, "Hisilicon" is being used all over the kernel - do you
intend to patch all places with similar changes like this one? Perhaps
just send a big tree-wide-patch instead and see what people think?
> */
>
> #include <linux/bitops.h>
Kind regards
Uffe
Hi!
> On Tue, 30 Mar 2021 at 08:43, Hao Fang <[email protected]> wrote:
> >
> > s/Hisilicon/HiSilicon/g.
> > It should use capital S, according to
> > https://www.hisilicon.com/en/terms-of-use.
> >
> > Signed-off-by: Hao Fang <[email protected]>
> > /*
> > * Copyright (c) 2013 Linaro Ltd.
> > - * Copyright (c) 2013 Hisilicon Limited.
> > + * Copyright (c) 2013 HiSilicon Limited.
>
> This change looks really silly to me, but I am not a lawyer - so I
> can't tell if this makes sense or not.
>
> In any case, "Hisilicon" is being used all over the kernel - do you
> intend to patch all places with similar changes like this one? Perhaps
> just send a big tree-wide-patch instead and see what people think?
Plus, I'd expect authors to submit changes to copyright notices.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
On 2021/3/30 18:38, Ulf Hansson wrote:
> On Tue, 30 Mar 2021 at 08:43, Hao Fang <[email protected]> wrote:
>>
>> s/Hisilicon/HiSilicon/g.
>> It should use capital S, according to
>> https://www.hisilicon.com/en/terms-of-use.
>>
>> Signed-off-by: Hao Fang <[email protected]>
>> ---
>> drivers/mmc/host/dw_mmc-k3.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/dw_mmc-k3.c b/drivers/mmc/host/dw_mmc-k3.c
>> index 29d2494..0311a37 100644
>> --- a/drivers/mmc/host/dw_mmc-k3.c
>> +++ b/drivers/mmc/host/dw_mmc-k3.c
>> @@ -1,7 +1,7 @@
>> // SPDX-License-Identifier: GPL-2.0-or-later
>> /*
>> * Copyright (c) 2013 Linaro Ltd.
>> - * Copyright (c) 2013 Hisilicon Limited.
>> + * Copyright (c) 2013 HiSilicon Limited.
>
> This change looks really silly to me, but I am not a lawyer - so I
> can't tell if this makes sense or not.
>
> In any case, "Hisilicon" is being used all over the kernel - do you
> intend to patch all places with similar changes like this one? Perhaps
> just send a big tree-wide-patch instead and see what people think?
>
Although HiSilicon has applied for two trademarks Hisilicon/HiSilicon,
there is only one English name for the company. We have consulted with
company's lawyer who suggested that should use a copyright statement
consistent with the official website.
Though the kernel has tons of "Hisilicon", I just fix the copyright,
and plan to send a commit to each subsystem where is uncorrect. Fortunately,
there are not many modules that have the problem, this is one of them.
Thanks.
Hao
>> */
>>
>> #include <linux/bitops.h>
>
> Kind regards
> Uffe
>
> .
>
On 2021/3/30 21:43, Pavel Machek wrote:
> Hi!
>
>> On Tue, 30 Mar 2021 at 08:43, Hao Fang <[email protected]> wrote:
>>>
>>> s/Hisilicon/HiSilicon/g.
>>> It should use capital S, according to
>>> https://www.hisilicon.com/en/terms-of-use.
>>>
>>> Signed-off-by: Hao Fang <[email protected]>
>
>>> /*
>>> * Copyright (c) 2013 Linaro Ltd.
>>> - * Copyright (c) 2013 Hisilicon Limited.
>>> + * Copyright (c) 2013 HiSilicon Limited.
>>
>> This change looks really silly to me, but I am not a lawyer - so I
>> can't tell if this makes sense or not.
>>
>> In any case, "Hisilicon" is being used all over the kernel - do you
>> intend to patch all places with similar changes like this one? Perhaps
>> just send a big tree-wide-patch instead and see what people think?
>
> Plus, I'd expect authors to submit changes to copyright notices.
>
Just add Reviewed-by or Acked-by! Thanks.
> Best regards,
> Pavel
>
On Tue, Mar 30, 2021 at 2:46 PM Hao Fang <[email protected]> wrote:
>
> s/Hisilicon/HiSilicon/g.
> It should use capital S, according to
> https://www.hisilicon.com/en/terms-of-use.
>
> Signed-off-by: Hao Fang <[email protected]>
Thanks for the fix.
Acked-by: Zhangfei Gao <[email protected]>
> ---
> drivers/mmc/host/dw_mmc-k3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-k3.c b/drivers/mmc/host/dw_mmc-k3.c
> index 29d2494..0311a37 100644
> --- a/drivers/mmc/host/dw_mmc-k3.c
> +++ b/drivers/mmc/host/dw_mmc-k3.c
> @@ -1,7 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0-or-later
> /*
> * Copyright (c) 2013 Linaro Ltd.
> - * Copyright (c) 2013 Hisilicon Limited.
> + * Copyright (c) 2013 HiSilicon Limited.
> */
>
> #include <linux/bitops.h>
> --
> 2.8.1
>
On Tue, 30 Mar 2021 at 16:27, fanghao (A) <[email protected]> wrote:
>
>
>
> On 2021/3/30 18:38, Ulf Hansson wrote:
> > On Tue, 30 Mar 2021 at 08:43, Hao Fang <[email protected]> wrote:
> >>
> >> s/Hisilicon/HiSilicon/g.
> >> It should use capital S, according to
> >> https://www.hisilicon.com/en/terms-of-use.
> >>
> >> Signed-off-by: Hao Fang <[email protected]>
> >> ---
> >> drivers/mmc/host/dw_mmc-k3.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/mmc/host/dw_mmc-k3.c b/drivers/mmc/host/dw_mmc-k3.c
> >> index 29d2494..0311a37 100644
> >> --- a/drivers/mmc/host/dw_mmc-k3.c
> >> +++ b/drivers/mmc/host/dw_mmc-k3.c
> >> @@ -1,7 +1,7 @@
> >> // SPDX-License-Identifier: GPL-2.0-or-later
> >> /*
> >> * Copyright (c) 2013 Linaro Ltd.
> >> - * Copyright (c) 2013 Hisilicon Limited.
> >> + * Copyright (c) 2013 HiSilicon Limited.
> >
> > This change looks really silly to me, but I am not a lawyer - so I
> > can't tell if this makes sense or not.
> >
> > In any case, "Hisilicon" is being used all over the kernel - do you
> > intend to patch all places with similar changes like this one? Perhaps
> > just send a big tree-wide-patch instead and see what people think?
> >
>
> Although HiSilicon has applied for two trademarks Hisilicon/HiSilicon,
> there is only one English name for the company. We have consulted with
> company's lawyer who suggested that should use a copyright statement
> consistent with the official website.
>
> Though the kernel has tons of "Hisilicon", I just fix the copyright,
> and plan to send a commit to each subsystem where is uncorrect. Fortunately,
> there are not many modules that have the problem, this is one of them.
git grep Hisilicon | grep Copyright | nl
gives 159 cases.
Although if you make one patch per subsystem that should be a lot
less, which seems like a reasonable approach to me.
[...]
So, applied for next, thanks!
Kind regards
Uffe