2013-05-03 06:27:30

by Jingoo Han

Subject: [PATCH 09/42] rtc: rtc-bfin: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by: Jingoo Han <[email protected]>
---
drivers/rtc/rtc-bfin.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/rtc/rtc-bfin.c b/drivers/rtc/rtc-bfin.c
index ad44ec5..0c53f45 100644
--- a/drivers/rtc/rtc-bfin.c
+++ b/drivers/rtc/rtc-bfin.c
@@ -391,7 +391,6 @@ static int bfin_rtc_remove(struct platform_device *pdev)
struct device *dev = &pdev->dev;

bfin_rtc_reset(dev, 0);
- platform_set_drvdata(pdev, NULL);

return 0;
}
--
1.7.2.5

2013-05-03 18:52:30

by Mike Frysinger

Subject: Re: [PATCH 09/42] rtc: rtc-bfin: remove unnecessary platform_set_drvdata()

Acked-by: Mike Frysinger <[email protected]>
-mike