2015-04-13 14:02:57

by Chen Gang

[permalink] [raw]
Subject: [PATCH v2] blackfin: Wire up missing syscalls

The related syscalls are below which may cause samples/kdbus building
break in next-20150401 tree, the related information and error:

CALL scripts/checksyscalls.sh
<stdin>:1223:2: warning: #warning syscall kcmp not implemented [-Wcpp]
<stdin>:1226:2: warning: #warning syscall finit_module not implemented [-Wcpp]
<stdin>:1229:2: warning: #warning syscall sched_setattr not implemented [-Wcpp]
<stdin>:1232:2: warning: #warning syscall sched_getattr not implemented [-Wcpp]
<stdin>:1235:2: warning: #warning syscall renameat2 not implemented [-Wcpp]
<stdin>:1238:2: warning: #warning syscall seccomp not implemented [-Wcpp]
<stdin>:1241:2: warning: #warning syscall getrandom not implemented [-Wcpp]
<stdin>:1244:2: warning: #warning syscall memfd_create not implemented [-Wcpp]
<stdin>:1247:2: warning: #warning syscall bpf not implemented [-Wcpp]
<stdin>:1250:2: warning: #warning syscall execveat not implemented [-Wcpp]
[...]
HOSTCC samples/kdbus/kdbus-workers
samples/kdbus/kdbus-workers.c: In function ‘prime_new’:
samples/kdbus/kdbus-workers.c:930:18: error: ‘__NR_memfd_create’ undeclared (first use in this function)
p->fd = syscall(__NR_memfd_create, "prime-area", MFD_CLOEXEC);
^
samples/kdbus/kdbus-workers.c:930:18: note: each undeclared identifier is reported only once for each function it appears in

Signed-off-by: Chen Gang <[email protected]>
---
arch/blackfin/include/uapi/asm/unistd.h | 12 +++++++++++-
arch/blackfin/mach-common/entry.S | 10 ++++++++++
2 files changed, 21 insertions(+), 1 deletion(-)

diff --git a/arch/blackfin/include/uapi/asm/unistd.h b/arch/blackfin/include/uapi/asm/unistd.h
index a451164..0cb9078 100644
--- a/arch/blackfin/include/uapi/asm/unistd.h
+++ b/arch/blackfin/include/uapi/asm/unistd.h
@@ -401,8 +401,18 @@
#define __NR_sendmmsg 380
#define __NR_process_vm_readv 381
#define __NR_process_vm_writev 382
+#define __NR_kcmp 383
+#define __NR_finit_module 384
+#define __NR_sched_setattr 385
+#define __NR_sched_getattr 386
+#define __NR_renameat2 387
+#define __NR_seccomp 388
+#define __NR_getrandom 389
+#define __NR_memfd_create 390
+#define __NR_bpf 391
+#define __NR_execveat 392

-#define __NR_syscall 383
+#define __NR_syscall 393 /* For internal using, not implemented */
#define NR_syscalls __NR_syscall

/* Old optional stuff no one actually uses */
diff --git a/arch/blackfin/mach-common/entry.S b/arch/blackfin/mach-common/entry.S
index 86b5a09..8d9431e 100644
--- a/arch/blackfin/mach-common/entry.S
+++ b/arch/blackfin/mach-common/entry.S
@@ -1694,6 +1694,16 @@ ENTRY(_sys_call_table)
.long _sys_sendmmsg /* 380 */
.long _sys_process_vm_readv
.long _sys_process_vm_writev
+ .long _sys_kcmp
+ .long _sys_finit_module
+ .long _sys_sched_setattr /* 385 */
+ .long _sys_sched_getattr
+ .long _sys_renameat2
+ .long _sys_seccomp
+ .long _sys_getrandom
+ .long _sys_memfd_create /* 390 */
+ .long _sys_bpf
+ .long _sys_execveat

.rept NR_syscalls-(.-_sys_call_table)/4
.long _sys_ni_syscall
--
1.9.3


2015-04-22 07:01:48

by Steven Miao

[permalink] [raw]
Subject: Re: [PATCH v2] blackfin: Wire up missing syscalls

Applied. Thanks.

On Mon, Apr 13, 2015 at 10:02 PM, Chen Gang <[email protected]> wrote:
> The related syscalls are below which may cause samples/kdbus building
> break in next-20150401 tree, the related information and error:
>
> CALL scripts/checksyscalls.sh
> <stdin>:1223:2: warning: #warning syscall kcmp not implemented [-Wcpp]
> <stdin>:1226:2: warning: #warning syscall finit_module not implemented [-Wcpp]
> <stdin>:1229:2: warning: #warning syscall sched_setattr not implemented [-Wcpp]
> <stdin>:1232:2: warning: #warning syscall sched_getattr not implemented [-Wcpp]
> <stdin>:1235:2: warning: #warning syscall renameat2 not implemented [-Wcpp]
> <stdin>:1238:2: warning: #warning syscall seccomp not implemented [-Wcpp]
> <stdin>:1241:2: warning: #warning syscall getrandom not implemented [-Wcpp]
> <stdin>:1244:2: warning: #warning syscall memfd_create not implemented [-Wcpp]
> <stdin>:1247:2: warning: #warning syscall bpf not implemented [-Wcpp]
> <stdin>:1250:2: warning: #warning syscall execveat not implemented [-Wcpp]
> [...]
> HOSTCC samples/kdbus/kdbus-workers
> samples/kdbus/kdbus-workers.c: In function ‘prime_new’:
> samples/kdbus/kdbus-workers.c:930:18: error: ‘__NR_memfd_create’ undeclared (first use in this function)
> p->fd = syscall(__NR_memfd_create, "prime-area", MFD_CLOEXEC);
> ^
> samples/kdbus/kdbus-workers.c:930:18: note: each undeclared identifier is reported only once for each function it appears in
>
> Signed-off-by: Chen Gang <[email protected]>
> ---
> arch/blackfin/include/uapi/asm/unistd.h | 12 +++++++++++-
> arch/blackfin/mach-common/entry.S | 10 ++++++++++
> 2 files changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/arch/blackfin/include/uapi/asm/unistd.h b/arch/blackfin/include/uapi/asm/unistd.h
> index a451164..0cb9078 100644
> --- a/arch/blackfin/include/uapi/asm/unistd.h
> +++ b/arch/blackfin/include/uapi/asm/unistd.h
> @@ -401,8 +401,18 @@
> #define __NR_sendmmsg 380
> #define __NR_process_vm_readv 381
> #define __NR_process_vm_writev 382
> +#define __NR_kcmp 383
> +#define __NR_finit_module 384
> +#define __NR_sched_setattr 385
> +#define __NR_sched_getattr 386
> +#define __NR_renameat2 387
> +#define __NR_seccomp 388
> +#define __NR_getrandom 389
> +#define __NR_memfd_create 390
> +#define __NR_bpf 391
> +#define __NR_execveat 392
>
> -#define __NR_syscall 383
> +#define __NR_syscall 393 /* For internal using, not implemented */
> #define NR_syscalls __NR_syscall
>
> /* Old optional stuff no one actually uses */
> diff --git a/arch/blackfin/mach-common/entry.S b/arch/blackfin/mach-common/entry.S
> index 86b5a09..8d9431e 100644
> --- a/arch/blackfin/mach-common/entry.S
> +++ b/arch/blackfin/mach-common/entry.S
> @@ -1694,6 +1694,16 @@ ENTRY(_sys_call_table)
> .long _sys_sendmmsg /* 380 */
> .long _sys_process_vm_readv
> .long _sys_process_vm_writev
> + .long _sys_kcmp
> + .long _sys_finit_module
> + .long _sys_sched_setattr /* 385 */
> + .long _sys_sched_getattr
> + .long _sys_renameat2
> + .long _sys_seccomp
> + .long _sys_getrandom
> + .long _sys_memfd_create /* 390 */
> + .long _sys_bpf
> + .long _sys_execveat
>
> .rept NR_syscalls-(.-_sys_call_table)/4
> .long _sys_ni_syscall
> --
> 1.9.3

2015-05-12 11:53:33

by Chen Gang

[permalink] [raw]
Subject: Re: [PATCH v2] blackfin: Wire up missing syscalls

On 04/22/2015 03:01 PM, Steven Miao wrote:
> Applied. Thanks.
>

Thank you for your work.

In next tree 20150511, it only has one applier (me), I guess we need
additional appliers (e.g. you), please help check. The related commit
is: "4f650a5 blackfin: Wire up missing syscalls"

Thanks.

> On Mon, Apr 13, 2015 at 10:02 PM, Chen Gang <[email protected]> wrote:
>> The related syscalls are below which may cause samples/kdbus building
>> break in next-20150401 tree, the related information and error:
>>
>> CALL scripts/checksyscalls.sh
>> <stdin>:1223:2: warning: #warning syscall kcmp not implemented [-Wcpp]
>> <stdin>:1226:2: warning: #warning syscall finit_module not implemented [-Wcpp]
>> <stdin>:1229:2: warning: #warning syscall sched_setattr not implemented [-Wcpp]
>> <stdin>:1232:2: warning: #warning syscall sched_getattr not implemented [-Wcpp]
>> <stdin>:1235:2: warning: #warning syscall renameat2 not implemented [-Wcpp]
>> <stdin>:1238:2: warning: #warning syscall seccomp not implemented [-Wcpp]
>> <stdin>:1241:2: warning: #warning syscall getrandom not implemented [-Wcpp]
>> <stdin>:1244:2: warning: #warning syscall memfd_create not implemented [-Wcpp]
>> <stdin>:1247:2: warning: #warning syscall bpf not implemented [-Wcpp]
>> <stdin>:1250:2: warning: #warning syscall execveat not implemented [-Wcpp]
>> [...]
>> HOSTCC samples/kdbus/kdbus-workers
>> samples/kdbus/kdbus-workers.c: In function ‘prime_new’:
>> samples/kdbus/kdbus-workers.c:930:18: error: ‘__NR_memfd_create’ undeclared (first use in this function)
>> p->fd = syscall(__NR_memfd_create, "prime-area", MFD_CLOEXEC);
>> ^
>> samples/kdbus/kdbus-workers.c:930:18: note: each undeclared identifier is reported only once for each function it appears in
>>
>> Signed-off-by: Chen Gang <[email protected]>
>> ---
>> arch/blackfin/include/uapi/asm/unistd.h | 12 +++++++++++-
>> arch/blackfin/mach-common/entry.S | 10 ++++++++++
>> 2 files changed, 21 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/blackfin/include/uapi/asm/unistd.h b/arch/blackfin/include/uapi/asm/unistd.h
>> index a451164..0cb9078 100644
>> --- a/arch/blackfin/include/uapi/asm/unistd.h
>> +++ b/arch/blackfin/include/uapi/asm/unistd.h
>> @@ -401,8 +401,18 @@
>> #define __NR_sendmmsg 380
>> #define __NR_process_vm_readv 381
>> #define __NR_process_vm_writev 382
>> +#define __NR_kcmp 383
>> +#define __NR_finit_module 384
>> +#define __NR_sched_setattr 385
>> +#define __NR_sched_getattr 386
>> +#define __NR_renameat2 387
>> +#define __NR_seccomp 388
>> +#define __NR_getrandom 389
>> +#define __NR_memfd_create 390
>> +#define __NR_bpf 391
>> +#define __NR_execveat 392
>>
>> -#define __NR_syscall 383
>> +#define __NR_syscall 393 /* For internal using, not implemented */
>> #define NR_syscalls __NR_syscall
>>
>> /* Old optional stuff no one actually uses */
>> diff --git a/arch/blackfin/mach-common/entry.S b/arch/blackfin/mach-common/entry.S
>> index 86b5a09..8d9431e 100644
>> --- a/arch/blackfin/mach-common/entry.S
>> +++ b/arch/blackfin/mach-common/entry.S
>> @@ -1694,6 +1694,16 @@ ENTRY(_sys_call_table)
>> .long _sys_sendmmsg /* 380 */
>> .long _sys_process_vm_readv
>> .long _sys_process_vm_writev
>> + .long _sys_kcmp
>> + .long _sys_finit_module
>> + .long _sys_sched_setattr /* 385 */
>> + .long _sys_sched_getattr
>> + .long _sys_renameat2
>> + .long _sys_seccomp
>> + .long _sys_getrandom
>> + .long _sys_memfd_create /* 390 */
>> + .long _sys_bpf
>> + .long _sys_execveat
>>
>> .rept NR_syscalls-(.-_sys_call_table)/4
>> .long _sys_ni_syscall
>> --
>> 1.9.3

--
Chen Gang

Open, share, and attitude like air, water, and life which God blessed