2014-02-12 10:18:39

by Paul Bolle

[permalink] [raw]
Subject: blackfin: Kconfig symbol VIDEO_MT9M114?

Steven, Sonic,

Your commit 54e4ff4d4024 ("blackfin: adi gpio driver and pinctrl driver
support") added a check for the Kconfig macro CONFIG_VIDEO_MT9M114. That
commit was added during the v3.13 release cycle.

There's no Kconfig symbol VIDEO_MT9M114 in mainline. And it doesn't look
like this was a typo. So why was that check added?

Regards,


Paul Bolle


2014-02-13 09:00:10

by Steven Miao

[permalink] [raw]
Subject: Re: blackfin: Kconfig symbol VIDEO_MT9M114?

Hi Paul,

On Wed, Feb 12, 2014 at 6:18 PM, Paul Bolle <[email protected]> wrote:
> Steven, Sonic,
>
> Your commit 54e4ff4d4024 ("blackfin: adi gpio driver and pinctrl driver
> support") added a check for the Kconfig macro CONFIG_VIDEO_MT9M114. That
> commit was added during the v3.13 release cycle.
>
> There's no Kconfig symbol VIDEO_MT9M114 in mainline. And it doesn't look
> like this was a typo. So why was that check added?
VIDEO_MT9M114 is from patch "Aptina mt9m114 HD digital image sensor
driver", but unfortunately this patch hasn't been accepted yet.
https://patchwork.linuxtv.org/patch/16308/
This Kconfig symbol should be removed until the mt9m114 driver is
accepted by mainline.

>
> Regards,
>
>
> Paul Bolle
>

-steven

2014-02-13 09:30:20

by Paul Bolle

[permalink] [raw]
Subject: Re: blackfin: Kconfig symbol VIDEO_MT9M114?

Hi Steven,

On Thu, 2014-02-13 at 17:00 +0800, Steven Miao wrote:
> VIDEO_MT9M114 is from patch "Aptina mt9m114 HD digital image sensor
> driver", but unfortunately this patch hasn't been accepted yet.
> https://patchwork.linuxtv.org/patch/16308/
> This Kconfig symbol should be removed until the mt9m114 driver is
> accepted by mainline.

Thanks for looking into this.

It's easy for me to submit a trivial patch to remove the one line
depending on these Kconfig macros. But it seems that line should be
added to the queue for that driver at the same time, otherwise we risk
losing it. So it's safer if you or the people working on that driver
coordinate that, isn't it?


Paul Bolle

2014-02-13 10:03:22

by Zhang, Sonic

[permalink] [raw]
Subject: RE: blackfin: Kconfig symbol VIDEO_MT9M114?

Hi Paul,

I will send out a patch to remove it.

Regards,

Sonic

>-----Original Message-----
>From: Paul Bolle [mailto:[email protected]]
>Sent: Thursday, February 13, 2014 5:30 PM
>To: Steven Miao
>Cc: Zhang, Sonic; Richard Weinberger; [email protected];
>open list:CAN NETWORK DRIVERS <[email protected]>, open
>list:NETWORKING DRIVERS <[email protected]>, open list
>Subject: Re: blackfin: Kconfig symbol VIDEO_MT9M114?
>
>Hi Steven,
>
>On Thu, 2014-02-13 at 17:00 +0800, Steven Miao wrote:
>> VIDEO_MT9M114 is from patch "Aptina mt9m114 HD digital image sensor
>> driver", but unfortunately this patch hasn't been accepted yet.
>> https://patchwork.linuxtv.org/patch/16308/
>> This Kconfig symbol should be removed until the mt9m114 driver is
>> accepted by mainline.
>
>Thanks for looking into this.
>
>It's easy for me to submit a trivial patch to remove the one line depending on these
>Kconfig macros. But it seems that line should be added to the queue for that driver at
>the same time, otherwise we risk losing it. So it's safer if you or the people working on
>that driver coordinate that, isn't it?
>
>
>Paul Bolle
>

????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?