2014-02-13 09:46:10

by Paul Bolle

Subject: Re: [uclinux-dist-devel] [PATCH] blackfin: bf60x: fix typo "CONFIG_PM_BFIN_WAKE_PA15_POL"

[Added current lists.]

On Wed, 2013-03-20 at 13:26 +0800, Steven Miao wrote:
> good catch, thanks

This typo is still present in v3.14-rc2. Was my patch perhaps lost?

> On Wed, Mar 20, 2013 at 7:33 AM, Paul Bolle <[email protected]>
> wrote:
> Signed-off-by: Paul Bolle <[email protected]>
> ---
> Obvious, isn't it? Introduced in v3.5, through commit
> 0fbd88ca20a68a633b565e1f5ba18ca64afb0c78 ("blackfin: bf60x:
> add wakeup source select"). Untested.
>
> arch/blackfin/mach-bf609/pm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/blackfin/mach-bf609/pm.c
> b/arch/blackfin/mach-bf609/pm.c
> index ad505d9..0cdd695 100644
> --- a/arch/blackfin/mach-bf609/pm.c
> +++ b/arch/blackfin/mach-bf609/pm.c
> @@ -210,7 +210,7 @@ void bf609_cpu_pm_enter(suspend_state_t
> state)
>
> #ifdef CONFIG_PM_BFIN_WAKE_PB15
> wakeup |= PB15WE;
> -# if CONFIG_PM_BFIN_WAKE_PA15_POL
> +# if CONFIG_PM_BFIN_WAKE_PB15_POL
> wakeup_pol |= PB15WE;
> # endif
> #endif
> --
> 1.7.11.7


Paul Bolle

2014-02-26 10:29:16

by Steven Miao

Subject: Re: [uclinux-dist-devel] [PATCH] blackfin: bf60x: fix typo "CONFIG_PM_BFIN_WAKE_PA15_POL"

Hi Paul,

On Thu, Feb 13, 2014 at 5:46 PM, Paul Bolle <[email protected]> wrote:
> [Added current lists.]
>
> On Wed, 2013-03-20 at 13:26 +0800, Steven Miao wrote:
>> good catch, thanks
>
> This typo is still present in v3.14-rc2. Was my patch perhaps lost?
Sorry for the late reply. I'v applied this patch to the blackfin tree
at that time, but it seems we made some mistakes after the maintainer
changed. I will apply it to 3.14 release.

>
>> On Wed, Mar 20, 2013 at 7:33 AM, Paul Bolle <[email protected]>
>> wrote:
>> Signed-off-by: Paul Bolle <[email protected]>
>> ---
>> Obvious, isn't it? Introduced in v3.5, through commit
>> 0fbd88ca20a68a633b565e1f5ba18ca64afb0c78 ("blackfin: bf60x:
>> add wakeup source select"). Untested.
>>
>> arch/blackfin/mach-bf609/pm.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/blackfin/mach-bf609/pm.c
>> b/arch/blackfin/mach-bf609/pm.c
>> index ad505d9..0cdd695 100644
>> --- a/arch/blackfin/mach-bf609/pm.c
>> +++ b/arch/blackfin/mach-bf609/pm.c
>> @@ -210,7 +210,7 @@ void bf609_cpu_pm_enter(suspend_state_t
>> state)
>>
>> #ifdef CONFIG_PM_BFIN_WAKE_PB15
>> wakeup |= PB15WE;
>> -# if CONFIG_PM_BFIN_WAKE_PA15_POL
>> +# if CONFIG_PM_BFIN_WAKE_PB15_POL
>> wakeup_pol |= PB15WE;
>> # endif
>> #endif
>> --
>> 1.7.11.7
>
>
> Paul Bolle
>
-steven