2021-05-26 07:06:18

by Randy Dunlap

Subject: [PATCH] xtensa: fix kconfig unmet dependency warning for HAVE_FUTEX_CMPXCHG

XTENSA should only select HAVE_FUTEX_CMPXCHG when FUTEX is
set/enabled. This prevents a kconfig warning.

WARNING: unmet direct dependencies detected for HAVE_FUTEX_CMPXCHG
Depends on [n]: FUTEX [=n]
Selected by [y]:
- XTENSA [=y] && !MMU [=n]

Fixes: d951ba21b959 ("xtensa: nommu: select HAVE_FUTEX_CMPXCHG")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Max Filippov <[email protected]>
Cc: Chris Zankel <[email protected]>
Cc: [email protected]
---
arch/xtensa/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20210525.orig/arch/xtensa/Kconfig
+++ linux-next-20210525/arch/xtensa/Kconfig
@@ -30,7 +30,7 @@ config XTENSA
select HAVE_DMA_CONTIGUOUS
select HAVE_EXIT_THREAD
select HAVE_FUNCTION_TRACER
- select HAVE_FUTEX_CMPXCHG if !MMU
+ select HAVE_FUTEX_CMPXCHG if !MMU && FUTEX
select HAVE_HW_BREAKPOINT if PERF_EVENTS
select HAVE_IRQ_TIME_ACCOUNTING
select HAVE_PCI

2021-05-27 00:58:17

by Max Filippov

Subject: Re: [PATCH] xtensa: fix kconfig unmet dependency warning for HAVE_FUTEX_CMPXCHG

On Wed, May 26, 2021 at 12:03 AM Randy Dunlap <[email protected]> wrote:
>
> XTENSA should only select HAVE_FUTEX_CMPXCHG when FUTEX is
> set/enabled. This prevents a kconfig warning.
>
> WARNING: unmet direct dependencies detected for HAVE_FUTEX_CMPXCHG
> Depends on [n]: FUTEX [=n]
> Selected by [y]:
> - XTENSA [=y] && !MMU [=n]
>
> Fixes: d951ba21b959 ("xtensa: nommu: select HAVE_FUTEX_CMPXCHG")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Max Filippov <[email protected]>
> Cc: Chris Zankel <[email protected]>
> Cc: [email protected]
> ---
> arch/xtensa/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied to my xtensa tree.

-- Max