2024-04-15 15:06:49

by Max Filippov

[permalink] [raw]
Subject: Re: [PATCH net-next v2 02/15] xtensa: remove the get_order() implementation

On Mon, Apr 15, 2024 at 6:21 AM Yunsheng Lin <[email protected]> wrote:
>
> As the get_order() implemented by xtensa supporting 'nsau'
> instruction seems be the same as the generic implementation
> in include/asm-generic/getorder.h when size is not a constant
> value as the generic implementation calling the fls*() is also
> utilizing the 'nsau' instruction for xtensa.
>
> So remove the get_order() implemented by xtensa, as using the
> generic implementation may enable the compiler to do the
> computing when size is a constant value instead of runtime
> computing and enable the using of get_order() in BUILD_BUG_ON()
> macro.
>
> Signed-off-by: Yunsheng Lin <[email protected]>
> ---
> arch/xtensa/include/asm/page.h | 18 ------------------
> 1 file changed, 18 deletions(-)

Acked-by: Max Filippov <[email protected]>

--
Thanks.
-- Max