2022-04-27 09:35:21

by Max Filippov

[permalink] [raw]
Subject: Re: [PATCH 4/9] ptrace/xtensa: Replace PT_SINGLESTEP with TIF_SINGLESTEP

On Tue, Apr 26, 2022 at 3:52 PM Eric W. Biederman <[email protected]> wrote:
>
> xtensa is the last user of the PT_SINGLESTEP flag. Changing tsk->ptrace in
> user_enable_single_step and user_disable_single_step without locking could
> potentiallly cause problems.
>
> So use a thread info flag instead of a flag in tsk->ptrace. Use TIF_SINGLESTEP
> that xtensa already had defined but unused.
>
> Remove the definitions of PT_SINGLESTEP and PT_BLOCKSTEP as they have no more users.
>
> Signed-off-by: "Eric W. Biederman" <[email protected]>
> ---
> arch/xtensa/kernel/ptrace.c | 4 ++--
> arch/xtensa/kernel/signal.c | 4 ++--
> include/linux/ptrace.h | 6 ------
> 3 files changed, 4 insertions(+), 10 deletions(-)

Acked-by: Max Filippov <[email protected]>

--
Thanks.
-- Max