2018-09-12 04:26:16

by Masahiro Yamada

[permalink] [raw]
Subject: [PATCH] xtensa: remove unnecessary KBUILD_SRC ifeq conditional

You can always prefix variant/platform header search paths with
$(srctree)/ because $(srctree) is '.' for in-tree building.

Signed-off-by: Masahiro Yamada <[email protected]>
---

arch/xtensa/Makefile | 4 ----
1 file changed, 4 deletions(-)

diff --git a/arch/xtensa/Makefile b/arch/xtensa/Makefile
index 295c120..d67e30fa 100644
--- a/arch/xtensa/Makefile
+++ b/arch/xtensa/Makefile
@@ -64,11 +64,7 @@ endif
vardirs := $(patsubst %,arch/xtensa/variants/%/,$(variant-y))
plfdirs := $(patsubst %,arch/xtensa/platforms/%/,$(platform-y))

-ifeq ($(KBUILD_SRC),)
-KBUILD_CPPFLAGS += $(patsubst %,-I%include,$(vardirs) $(plfdirs))
-else
KBUILD_CPPFLAGS += $(patsubst %,-I$(srctree)/%include,$(vardirs) $(plfdirs))
-endif

KBUILD_DEFCONFIG := iss_defconfig

--
2.7.4



2018-09-12 05:12:41

by Max Filippov

[permalink] [raw]
Subject: Re: [PATCH] xtensa: remove unnecessary KBUILD_SRC ifeq conditional

On Tue, Sep 11, 2018 at 9:25 PM, Masahiro Yamada
<[email protected]> wrote:
> You can always prefix variant/platform header search paths with
> $(srctree)/ because $(srctree) is '.' for in-tree building.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> arch/xtensa/Makefile | 4 ----
> 1 file changed, 4 deletions(-)

Thanks, applied to my xtensa tree.

--
Thanks.
-- Max