2015-08-21 15:57:44

by Guenter Roeck

Subject: xtensa builds broken in -next due to 'kbuild: Fix .text.unlikely placement'

Lots of 'literal placed after use' messages in all xtensa builds,

Interestingly, it looks like the culprit is not the placement of
.text.unlikely, but the changed placement of .text.hot (which the
patch states wasn't necessary).

Guenter

---
bisect log:

# bad: [1ef981bcd18de26dc78bc79f092d6f4bb25e0e8f] Add linux-next specific files for 20150821
# good: [2c6625cd545bdd66acff14f3394865d43920a5c7] Linux 4.2-rc7
git bisect start 'HEAD' 'v4.2-rc7'
# bad: [de7f2011b5252a4056a7bc315b133c84efb698fe] Merge remote-tracking branch 'drm/drm-next'
git bisect bad de7f2011b5252a4056a7bc315b133c84efb698fe
# bad: [ff95427048bb6b7e757a00961381db0fbdaf8169] Merge remote-tracking branch 'kbuild/for-next'
git bisect bad ff95427048bb6b7e757a00961381db0fbdaf8169
# good: [9f1d0e9bfa91ba25142d3352b44f46099cf2e9f8] Merge remote-tracking branch 'metag/for-next'
git bisect good 9f1d0e9bfa91ba25142d3352b44f46099cf2e9f8
# good: [b846bf1856e496dd1a8e00aab7b193929e7146e1] Merge remote-tracking branch 'pci/next'
git bisect good b846bf1856e496dd1a8e00aab7b193929e7146e1
# good: [5d26c12b70e96bf900da90844e9f466f2700f310] Merge branch 'v4l_for_linus' into to_next
git bisect good 5d26c12b70e96bf900da90844e9f466f2700f310
# good: [26ca49c56dbd19f2e5e40f9d985b54a7262494d3] Merge remote-tracking branch 'hid/for-next'
git bisect good 26ca49c56dbd19f2e5e40f9d985b54a7262494d3
# good: [f883cfcc111c0484e9e68f19bba576a11cc1a273] Merge remote-tracking branch 'hwmon-staging/hwmon-next'
git bisect good f883cfcc111c0484e9e68f19bba576a11cc1a273
# good: [79e4ae22ea9252d281092a71ce6fa9d337cd1e0c] Merge branch 'kbuild/kconfig' into kbuild/for-next
git bisect good 79e4ae22ea9252d281092a71ce6fa9d337cd1e0c
# good: [a41bf0af31f0047f58ea02163bfe17a6ede63edf] Merge branch 'kbuild/misc' into kbuild/for-next
git bisect good a41bf0af31f0047f58ea02163bfe17a6ede63edf
# good: [82222a3d0da8f0a50a656a90d258218514de427f] Merge branch 'kbuild/misc' into kbuild/for-next
git bisect good 82222a3d0da8f0a50a656a90d258218514de427f
# good: [4e0e427684b9b13ae4c9ae854ec4312fd47dafa1] Merge branch 'kbuild/kconfig' into kbuild/for-next
git bisect good 4e0e427684b9b13ae4c9ae854ec4312fd47dafa1
# bad: [1c722503fa81888c936a8d1a5052daec859f1a7c] genksyms: Duplicate function pointer type definitions segfault
git bisect bad 1c722503fa81888c936a8d1a5052daec859f1a7c
# bad: [9bebe9e5b0f3109a14000df25308c2971f872605] kbuild: Fix .text.unlikely placement
git bisect bad 9bebe9e5b0f3109a14000df25308c2971f872605
# good: [3c0561e0043fe870426b445890ab93204332ae39] Avoid conflict with host definitions when cross-compiling
git bisect good 3c0561e0043fe870426b445890ab93204332ae39
# first bad commit: [9bebe9e5b0f3109a14000df25308c2971f872605] kbuild: Fix .text.unlikely placement

2015-08-21 16:34:21

by Max Filippov

Subject: Re: xtensa builds broken in -next due to 'kbuild: Fix .text.unlikely placement'

On Fri, Aug 21, 2015 at 6:57 PM, Guenter Roeck <[email protected]> wrote:
> Lots of 'literal placed after use' messages in all xtensa builds,
>
> Interestingly, it looks like the culprit is not the placement of
> .text.unlikely, but the changed placement of .text.hot (which the
> patch states wasn't necessary).

Yeah, exactly the type of change I had in mind posting this:
http://lists.linux-xtensa.org/pipermail/linux-xtensa/Week-of-Mon-20150330/001913.html
BTW with that sed script it works.

> ---
> bisect log:
>
> # bad: [1ef981bcd18de26dc78bc79f092d6f4bb25e0e8f] Add linux-next specific files for 20150821
> # good: [2c6625cd545bdd66acff14f3394865d43920a5c7] Linux 4.2-rc7
> git bisect start 'HEAD' 'v4.2-rc7'
> # bad: [de7f2011b5252a4056a7bc315b133c84efb698fe] Merge remote-tracking branch 'drm/drm-next'
> git bisect bad de7f2011b5252a4056a7bc315b133c84efb698fe
> # bad: [ff95427048bb6b7e757a00961381db0fbdaf8169] Merge remote-tracking branch 'kbuild/for-next'
> git bisect bad ff95427048bb6b7e757a00961381db0fbdaf8169
> # good: [9f1d0e9bfa91ba25142d3352b44f46099cf2e9f8] Merge remote-tracking branch 'metag/for-next'
> git bisect good 9f1d0e9bfa91ba25142d3352b44f46099cf2e9f8
> # good: [b846bf1856e496dd1a8e00aab7b193929e7146e1] Merge remote-tracking branch 'pci/next'
> git bisect good b846bf1856e496dd1a8e00aab7b193929e7146e1
> # good: [5d26c12b70e96bf900da90844e9f466f2700f310] Merge branch 'v4l_for_linus' into to_next
> git bisect good 5d26c12b70e96bf900da90844e9f466f2700f310
> # good: [26ca49c56dbd19f2e5e40f9d985b54a7262494d3] Merge remote-tracking branch 'hid/for-next'
> git bisect good 26ca49c56dbd19f2e5e40f9d985b54a7262494d3
> # good: [f883cfcc111c0484e9e68f19bba576a11cc1a273] Merge remote-tracking branch 'hwmon-staging/hwmon-next'
> git bisect good f883cfcc111c0484e9e68f19bba576a11cc1a273
> # good: [79e4ae22ea9252d281092a71ce6fa9d337cd1e0c] Merge branch 'kbuild/kconfig' into kbuild/for-next
> git bisect good 79e4ae22ea9252d281092a71ce6fa9d337cd1e0c
> # good: [a41bf0af31f0047f58ea02163bfe17a6ede63edf] Merge branch 'kbuild/misc' into kbuild/for-next
> git bisect good a41bf0af31f0047f58ea02163bfe17a6ede63edf
> # good: [82222a3d0da8f0a50a656a90d258218514de427f] Merge branch 'kbuild/misc' into kbuild/for-next
> git bisect good 82222a3d0da8f0a50a656a90d258218514de427f
> # good: [4e0e427684b9b13ae4c9ae854ec4312fd47dafa1] Merge branch 'kbuild/kconfig' into kbuild/for-next
> git bisect good 4e0e427684b9b13ae4c9ae854ec4312fd47dafa1
> # bad: [1c722503fa81888c936a8d1a5052daec859f1a7c] genksyms: Duplicate function pointer type definitions segfault
> git bisect bad 1c722503fa81888c936a8d1a5052daec859f1a7c
> # bad: [9bebe9e5b0f3109a14000df25308c2971f872605] kbuild: Fix .text.unlikely placement
> git bisect bad 9bebe9e5b0f3109a14000df25308c2971f872605
> # good: [3c0561e0043fe870426b445890ab93204332ae39] Avoid conflict with host definitions when cross-compiling
> git bisect good 3c0561e0043fe870426b445890ab93204332ae39
> # first bad commit: [9bebe9e5b0f3109a14000df25308c2971f872605] kbuild: Fix .text.unlikely placement



--
Thanks.
-- Max

2015-08-21 17:07:04

by Guenter Roeck

Subject: Re: xtensa builds broken in -next due to 'kbuild: Fix .text.unlikely placement'

On Fri, Aug 21, 2015 at 07:34:19PM +0300, Max Filippov wrote:
> On Fri, Aug 21, 2015 at 6:57 PM, Guenter Roeck <[email protected]> wrote:
> > Lots of 'literal placed after use' messages in all xtensa builds,
> >
> > Interestingly, it looks like the culprit is not the placement of
> > .text.unlikely, but the changed placement of .text.hot (which the
> > patch states wasn't necessary).
>
> Yeah, exactly the type of change I had in mind posting this:
> http://lists.linux-xtensa.org/pipermail/linux-xtensa/Week-of-Mon-20150330/001913.html
> BTW with that sed script it works.
>
Ah that one. Guess you made your point.
Maybe rebase to -next if needed and post again ?

Guenter