2018-11-05 23:10:16

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Signed-off-by missing for commit in the xtensa tree

Hi Max,

Commit

12e90ddd8dbf ("Revert "xtensa: xtfpga: implement platform DMA address helpers"")

is missing a Signed-off-by from its author and committer.

Reverts are commits too.

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2018-11-05 23:15:41

by Max Filippov

[permalink] [raw]
Subject: Re: linux-next: Signed-off-by missing for commit in the xtensa tree

Hi Stephen,

On Mon, Nov 5, 2018 at 3:09 PM Stephen Rothwell <[email protected]> wrote:
> Commit
>
> 12e90ddd8dbf ("Revert "xtensa: xtfpga: implement platform DMA address helpers"")
>
> is missing a Signed-off-by from its author and committer.
>
> Reverts are commits too.

Thanks for catching that. Should I rewrite that branch fixing up that commit?

--
Thanks.
-- Max

2018-11-05 23:20:25

by Stephen Rothwell

[permalink] [raw]
Subject: Re: linux-next: Signed-off-by missing for commit in the xtensa tree

Hi Max,

On Mon, 5 Nov 2018 15:14:44 -0800 Max Filippov <[email protected]> wrote:
>
> On Mon, Nov 5, 2018 at 3:09 PM Stephen Rothwell <[email protected]> wrote:
> > Commit
> >
> > 12e90ddd8dbf ("Revert "xtensa: xtfpga: implement platform DMA address helpers"")
> >
> > is missing a Signed-off-by from its author and committer.
> >
> > Reverts are commits too.
>
> Thanks for catching that. Should I rewrite that branch fixing up that commit?

There is nothing else you can do. The only reason not to is if you
strictly do not rebase your branch (or there has been lots of other
activity - which there is not in this case).

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature