2019-07-05 13:19:01

by Yue Haibing

Subject: [PATCH] gpio: tegra: Fix build error without CONFIG_DEBUG_FS

If CONFIG_DEBUG_FS is not set, building fails:

drivers/gpio/gpio-tegra.c: In function tegra_gpio_probe:
drivers/gpio/gpio-tegra.c:665:2: error: implicit declaration of function debugfs_create_file;
did you mean bus_create_file? [-Werror=implicit-function-declaration]
debugfs_create_file("tegra_gpio", 0444, NULL, tgi,
^~~~~~~~~~~~~~~~~~~
bus_create_file
drivers/gpio/gpio-tegra.c:666:9: error: tegra_dbg_gpio_fops undeclared (first use in this function);
did you mean tegra_gpio_pm_ops?
&tegra_dbg_gpio_fops);
^~~~~~~~~~~~~~~~~~~
tegra_gpio_pm_ops

Reported-by: Hulk Robot <[email protected]>
Fixes: a4de43049a1d ("gpio: tegra: Clean-up debugfs initialisation")
Signed-off-by: YueHaibing <[email protected]>
---
drivers/gpio/gpio-tegra.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
index 59b99d8..40fd6bd 100644
--- a/drivers/gpio/gpio-tegra.c
+++ b/drivers/gpio/gpio-tegra.c
@@ -662,8 +662,10 @@ static int tegra_gpio_probe(struct platform_device *pdev)
}
}

+#ifdef CONFIG_DEBUG_FS
debugfs_create_file("tegra_gpio", 0444, NULL, tgi,
&tegra_dbg_gpio_fops);
+#endif

return 0;
}
--
2.7.4

2019-07-05 13:37:00

by Bartosz Golaszewski

Subject: Re: [PATCH] gpio: tegra: Fix build error without CONFIG_DEBUG_FS

pt., 5 lip 2019 o 14:44 Yuehaibing <[email protected]> napisał(a):
>
> On 2019/7/5 20:40, Bartosz Golaszewski wrote:
> > pt., 5 lip 2019 o 14:34 YueHaibing <[email protected]> napisał(a):
> >>
> >> If CONFIG_DEBUG_FS is not set, building fails:
> >>
> >> drivers/gpio/gpio-tegra.c: In function tegra_gpio_probe:
> >> drivers/gpio/gpio-tegra.c:665:2: error: implicit declaration of function debugfs_create_file;
> >> did you mean bus_create_file? [-Werror=implicit-function-declaration]
> >> debugfs_create_file("tegra_gpio", 0444, NULL, tgi,
> >> ^~~~~~~~~~~~~~~~~~~
> >> bus_create_file
> >> drivers/gpio/gpio-tegra.c:666:9: error: tegra_dbg_gpio_fops undeclared (first use in this function);
> >> did you mean tegra_gpio_pm_ops?
> >> &tegra_dbg_gpio_fops);
> >> ^~~~~~~~~~~~~~~~~~~
> >> tegra_gpio_pm_ops
> >>
> >> Reported-by: Hulk Robot <[email protected]>
> >> Fixes: a4de43049a1d ("gpio: tegra: Clean-up debugfs initialisation")
> >> Signed-off-by: YueHaibing <[email protected]>
> >> ---
> >> drivers/gpio/gpio-tegra.c | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
> >> index 59b99d8..40fd6bd 100644
> >> --- a/drivers/gpio/gpio-tegra.c
> >> +++ b/drivers/gpio/gpio-tegra.c
> >> @@ -662,8 +662,10 @@ static int tegra_gpio_probe(struct platform_device *pdev)
> >> }
> >> }
> >>
> >> +#ifdef CONFIG_DEBUG_FS
> >> debugfs_create_file("tegra_gpio", 0444, NULL, tgi,
> >> &tegra_dbg_gpio_fops);
> >> +#endif
> >>
> >> return 0;
> >> }
> >> --
> >> 2.7.4
> >>
> >>
> >
> > Nack, there are inline stubs for all debugfs functions in
> > ./include/linux/debugfs.h if CONFIG_DEBUG_FS is not selected. Just
> > move the #include <linux/debugfs.h> to the top of the source file.
>
> yes, agree this, but 'tegra_dbg_gpio_fops' is still undeclared.
>
> >
> > Bart
> >
> > .
> >
>

Can you attach the config you're using?

Bart

2019-07-05 14:06:31

by Bartosz Golaszewski

Subject: Re: [PATCH] gpio: tegra: Fix build error without CONFIG_DEBUG_FS

pt., 5 lip 2019 o 14:34 YueHaibing <[email protected]> napisał(a):
>
> If CONFIG_DEBUG_FS is not set, building fails:
>
> drivers/gpio/gpio-tegra.c: In function tegra_gpio_probe:
> drivers/gpio/gpio-tegra.c:665:2: error: implicit declaration of function debugfs_create_file;
> did you mean bus_create_file? [-Werror=implicit-function-declaration]
> debugfs_create_file("tegra_gpio", 0444, NULL, tgi,
> ^~~~~~~~~~~~~~~~~~~
> bus_create_file
> drivers/gpio/gpio-tegra.c:666:9: error: tegra_dbg_gpio_fops undeclared (first use in this function);
> did you mean tegra_gpio_pm_ops?
> &tegra_dbg_gpio_fops);
> ^~~~~~~~~~~~~~~~~~~
> tegra_gpio_pm_ops
>
> Reported-by: Hulk Robot <[email protected]>
> Fixes: a4de43049a1d ("gpio: tegra: Clean-up debugfs initialisation")
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/gpio/gpio-tegra.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
> index 59b99d8..40fd6bd 100644
> --- a/drivers/gpio/gpio-tegra.c
> +++ b/drivers/gpio/gpio-tegra.c
> @@ -662,8 +662,10 @@ static int tegra_gpio_probe(struct platform_device *pdev)
> }
> }
>
> +#ifdef CONFIG_DEBUG_FS
> debugfs_create_file("tegra_gpio", 0444, NULL, tgi,
> &tegra_dbg_gpio_fops);
> +#endif
>
> return 0;
> }
> --
> 2.7.4
>
>

Nack, there are inline stubs for all debugfs functions in
./include/linux/debugfs.h if CONFIG_DEBUG_FS is not selected. Just
move the #include <linux/debugfs.h> to the top of the source file.

Bart

2019-07-05 14:07:34

by Yue Haibing

Subject: Re: [PATCH] gpio: tegra: Fix build error without CONFIG_DEBUG_FS

On 2019/7/5 20:40, Bartosz Golaszewski wrote:
> pt., 5 lip 2019 o 14:34 YueHaibing <[email protected]> napisał(a):
>>
>> If CONFIG_DEBUG_FS is not set, building fails:
>>
>> drivers/gpio/gpio-tegra.c: In function tegra_gpio_probe:
>> drivers/gpio/gpio-tegra.c:665:2: error: implicit declaration of function debugfs_create_file;
>> did you mean bus_create_file? [-Werror=implicit-function-declaration]
>> debugfs_create_file("tegra_gpio", 0444, NULL, tgi,
>> ^~~~~~~~~~~~~~~~~~~
>> bus_create_file
>> drivers/gpio/gpio-tegra.c:666:9: error: tegra_dbg_gpio_fops undeclared (first use in this function);
>> did you mean tegra_gpio_pm_ops?
>> &tegra_dbg_gpio_fops);
>> ^~~~~~~~~~~~~~~~~~~
>> tegra_gpio_pm_ops
>>
>> Reported-by: Hulk Robot <[email protected]>
>> Fixes: a4de43049a1d ("gpio: tegra: Clean-up debugfs initialisation")
>> Signed-off-by: YueHaibing <[email protected]>
>> ---
>> drivers/gpio/gpio-tegra.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
>> index 59b99d8..40fd6bd 100644
>> --- a/drivers/gpio/gpio-tegra.c
>> +++ b/drivers/gpio/gpio-tegra.c
>> @@ -662,8 +662,10 @@ static int tegra_gpio_probe(struct platform_device *pdev)
>> }
>> }
>>
>> +#ifdef CONFIG_DEBUG_FS
>> debugfs_create_file("tegra_gpio", 0444, NULL, tgi,
>> &tegra_dbg_gpio_fops);
>> +#endif
>>
>> return 0;
>> }
>> --
>> 2.7.4
>>
>>
>
> Nack, there are inline stubs for all debugfs functions in
> ./include/linux/debugfs.h if CONFIG_DEBUG_FS is not selected. Just
> move the #include <linux/debugfs.h> to the top of the source file.

yes, agree this, but 'tegra_dbg_gpio_fops' is still undeclared.

>
> Bart
>
> .
>

2019-07-05 14:08:02

by Bartosz Golaszewski

Subject: Re: [PATCH] gpio: tegra: Fix build error without CONFIG_DEBUG_FS

pt., 5 lip 2019 o 14:56 Bartosz Golaszewski
<[email protected]> napisał(a):
>
> pt., 5 lip 2019 o 14:44 Yuehaibing <[email protected]> napisał(a):
> >
> > On 2019/7/5 20:40, Bartosz Golaszewski wrote:
> > > pt., 5 lip 2019 o 14:34 YueHaibing <[email protected]> napisał(a):
> > >>
> > >> If CONFIG_DEBUG_FS is not set, building fails:
> > >>
> > >> drivers/gpio/gpio-tegra.c: In function tegra_gpio_probe:
> > >> drivers/gpio/gpio-tegra.c:665:2: error: implicit declaration of function debugfs_create_file;
> > >> did you mean bus_create_file? [-Werror=implicit-function-declaration]
> > >> debugfs_create_file("tegra_gpio", 0444, NULL, tgi,
> > >> ^~~~~~~~~~~~~~~~~~~
> > >> bus_create_file
> > >> drivers/gpio/gpio-tegra.c:666:9: error: tegra_dbg_gpio_fops undeclared (first use in this function);
> > >> did you mean tegra_gpio_pm_ops?
> > >> &tegra_dbg_gpio_fops);
> > >> ^~~~~~~~~~~~~~~~~~~
> > >> tegra_gpio_pm_ops
> > >>
> > >> Reported-by: Hulk Robot <[email protected]>
> > >> Fixes: a4de43049a1d ("gpio: tegra: Clean-up debugfs initialisation")
> > >> Signed-off-by: YueHaibing <[email protected]>
> > >> ---
> > >> drivers/gpio/gpio-tegra.c | 2 ++
> > >> 1 file changed, 2 insertions(+)
> > >>
> > >> diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c
> > >> index 59b99d8..40fd6bd 100644
> > >> --- a/drivers/gpio/gpio-tegra.c
> > >> +++ b/drivers/gpio/gpio-tegra.c
> > >> @@ -662,8 +662,10 @@ static int tegra_gpio_probe(struct platform_device *pdev)
> > >> }
> > >> }
> > >>
> > >> +#ifdef CONFIG_DEBUG_FS
> > >> debugfs_create_file("tegra_gpio", 0444, NULL, tgi,
> > >> &tegra_dbg_gpio_fops);
> > >> +#endif
> > >>
> > >> return 0;
> > >> }
> > >> --
> > >> 2.7.4
> > >>
> > >>
> > >
> > > Nack, there are inline stubs for all debugfs functions in
> > > ./include/linux/debugfs.h if CONFIG_DEBUG_FS is not selected. Just
> > > move the #include <linux/debugfs.h> to the top of the source file.
> >
> > yes, agree this, but 'tegra_dbg_gpio_fops' is still undeclared.
> >
> > >
> > > Bart
> > >
> > > .
> > >
> >
>
> Can you attach the config you're using?
>
> Bart

Wait, nevermind. I think that commit a4de43049a1d ("gpio: tegra:
Clean-up debugfs initialisation") is wrong and we missed that. Linus
what do you think about reverting it?

Bart

2019-07-06 22:35:24

by Linus Walleij

Subject: Re: [PATCH] gpio: tegra: Fix build error without CONFIG_DEBUG_FS

On Fri, Jul 5, 2019 at 2:59 PM Bartosz Golaszewski
<[email protected]> wrote:

> Wait, nevermind. I think that commit a4de43049a1d ("gpio: tegra:
> Clean-up debugfs initialisation") is wrong and we missed that. Linus
> what do you think about reverting it?

OK I reverted it.

Linus