2020-12-25 09:36:32

by Yoshihiro Shimoda

Subject: [PATCH v8 08/12] gpio: bd9571mwv: Add BD9574MWF support

Add support for BD9574MWF which is similar chip with BD9571MWV.
Note that BD9574MWF has additional features "RECOV_GPOUT",
"FREQSEL" and "RTC_IN", but supports GPIO function only.

Signed-off-by: Yoshihiro Shimoda <[email protected]>
Reviewed-by: Matti Vaittinen <[email protected]>
---
drivers/gpio/gpio-bd9571mwv.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-bd9571mwv.c b/drivers/gpio/gpio-bd9571mwv.c
index 0e5395f..df6102b 100644
--- a/drivers/gpio/gpio-bd9571mwv.c
+++ b/drivers/gpio/gpio-bd9571mwv.c
@@ -1,6 +1,6 @@
// SPDX-License-Identifier: GPL-2.0-only
/*
- * ROHM BD9571MWV-M GPIO driver
+ * ROHM BD9571MWV-M and BD9574MWF-M GPIO driver
*
* Copyright (C) 2017 Marek Vasut <[email protected]>
*
@@ -10,6 +10,7 @@
*/

#include <linux/gpio/driver.h>
+#include <linux/mfd/rohm-generic.h>
#include <linux/module.h>
#include <linux/platform_device.h>

@@ -118,7 +119,8 @@ static int bd9571mwv_gpio_probe(struct platform_device *pdev)
}

static const struct platform_device_id bd9571mwv_gpio_id_table[] = {
- { "bd9571mwv-gpio", },
+ { "bd9571mwv-gpio", ROHM_CHIP_TYPE_BD9571 },
+ { "bd9574mwf-gpio", ROHM_CHIP_TYPE_BD9574 },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(platform, bd9571mwv_gpio_id_table);
--
2.7.4

2021-01-03 15:50:12

by Bartosz Golaszewski

Subject: Re: [PATCH v8 08/12] gpio: bd9571mwv: Add BD9574MWF support

On Fri, Dec 25, 2020 at 10:33 AM Yoshihiro Shimoda
<[email protected]> wrote:
>
> Add support for BD9574MWF which is similar chip with BD9571MWV.
> Note that BD9574MWF has additional features "RECOV_GPOUT",
> "FREQSEL" and "RTC_IN", but supports GPIO function only.
>
> Signed-off-by: Yoshihiro Shimoda <[email protected]>
> Reviewed-by: Matti Vaittinen <[email protected]>
> ---
> drivers/gpio/gpio-bd9571mwv.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-bd9571mwv.c b/drivers/gpio/gpio-bd9571mwv.c
> index 0e5395f..df6102b 100644
> --- a/drivers/gpio/gpio-bd9571mwv.c
> +++ b/drivers/gpio/gpio-bd9571mwv.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0-only
> /*
> - * ROHM BD9571MWV-M GPIO driver
> + * ROHM BD9571MWV-M and BD9574MWF-M GPIO driver
> *
> * Copyright (C) 2017 Marek Vasut <[email protected]>
> *
> @@ -10,6 +10,7 @@
> */
>
> #include <linux/gpio/driver.h>
> +#include <linux/mfd/rohm-generic.h>
> #include <linux/module.h>
> #include <linux/platform_device.h>
>
> @@ -118,7 +119,8 @@ static int bd9571mwv_gpio_probe(struct platform_device *pdev)
> }
>
> static const struct platform_device_id bd9571mwv_gpio_id_table[] = {
> - { "bd9571mwv-gpio", },
> + { "bd9571mwv-gpio", ROHM_CHIP_TYPE_BD9571 },
> + { "bd9574mwf-gpio", ROHM_CHIP_TYPE_BD9574 },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(platform, bd9571mwv_gpio_id_table);
> --
> 2.7.4
>

Acked-by: Bartosz Golaszewski <[email protected]>