2021-09-16 23:41:42

by Krzysztof Kozlowski

Subject: [PATCH 1/2] gpio: max77620: drop unneeded MODULE_ALIAS

The MODULE_DEVICE_TABLE already creates proper alias for platform
driver. Having another MODULE_ALIAS causes the alias to be duplicated.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/gpio/gpio-max77620.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpio/gpio-max77620.c b/drivers/gpio/gpio-max77620.c
index 82b3a913005d..ebf9dea6546b 100644
--- a/drivers/gpio/gpio-max77620.c
+++ b/drivers/gpio/gpio-max77620.c
@@ -365,5 +365,4 @@ module_platform_driver(max77620_gpio_driver);
MODULE_DESCRIPTION("GPIO interface for MAX77620 and MAX20024 PMIC");
MODULE_AUTHOR("Laxman Dewangan <[email protected]>");
MODULE_AUTHOR("Chaitanya Bandi <[email protected]>");
-MODULE_ALIAS("platform:max77620-gpio");
MODULE_LICENSE("GPL v2");
--
2.30.2

2021-09-22 10:16:55

by Bartosz Golaszewski

Subject: Re: [PATCH 1/2] gpio: max77620: drop unneeded MODULE_ALIAS

On Thu, Sep 16, 2021 at 6:46 PM Krzysztof Kozlowski
<[email protected]> wrote:
>
> The MODULE_DEVICE_TABLE already creates proper alias for platform
> driver. Having another MODULE_ALIAS causes the alias to be duplicated.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> drivers/gpio/gpio-max77620.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-max77620.c b/drivers/gpio/gpio-max77620.c
> index 82b3a913005d..ebf9dea6546b 100644
> --- a/drivers/gpio/gpio-max77620.c
> +++ b/drivers/gpio/gpio-max77620.c
> @@ -365,5 +365,4 @@ module_platform_driver(max77620_gpio_driver);
> MODULE_DESCRIPTION("GPIO interface for MAX77620 and MAX20024 PMIC");
> MODULE_AUTHOR("Laxman Dewangan <[email protected]>");
> MODULE_AUTHOR("Chaitanya Bandi <[email protected]>");
> -MODULE_ALIAS("platform:max77620-gpio");
> MODULE_LICENSE("GPL v2");
> --
> 2.30.2
>

Applied, thanks!

Bart