2020-01-18 20:07:25

by sachin agarwal

Subject: [PATCH 4/4] GPIO: creg-snps: fixed a typo

we had written "valiue" rather than "value" and "it's" rather than "its".

Signed-off-by: Sachin Agarwal <[email protected]>
---
drivers/gpio/gpio-creg-snps.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-creg-snps.c b/drivers/gpio/gpio-creg-snps.c
index ff19a8ad5663..1d0827e79703 100644
--- a/drivers/gpio/gpio-creg-snps.c
+++ b/drivers/gpio/gpio-creg-snps.c
@@ -64,11 +64,11 @@ static int creg_gpio_validate_pg(struct device *dev, struct creg_gpio *hcg,
if (layout->bit_per_gpio[i] < 1 || layout->bit_per_gpio[i] > 8)
return -EINVAL;

- /* Check that on valiue fits it's placeholder */
+ /* Check that on value fits its placeholder */
if (GENMASK(31, layout->bit_per_gpio[i]) & layout->on[i])
return -EINVAL;

- /* Check that off valiue fits it's placeholder */
+ /* Check that off value fits its placeholder */
if (GENMASK(31, layout->bit_per_gpio[i]) & layout->off[i])
return -EINVAL;

--
2.24.1

2020-01-29 14:53:32

by Bartosz Golaszewski

Subject: Re: [PATCH 4/4] GPIO: creg-snps: fixed a typo

sob., 18 sty 2020 o 21:06 sachin agarwal <[email protected]> napisał(a):
>
> we had written "valiue" rather than "value" and "it's" rather than "its".
>
> Signed-off-by: Sachin Agarwal <[email protected]>
> ---
> drivers/gpio/gpio-creg-snps.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-creg-snps.c b/drivers/gpio/gpio-creg-snps.c
> index ff19a8ad5663..1d0827e79703 100644
> --- a/drivers/gpio/gpio-creg-snps.c
> +++ b/drivers/gpio/gpio-creg-snps.c
> @@ -64,11 +64,11 @@ static int creg_gpio_validate_pg(struct device *dev, struct creg_gpio *hcg,
> if (layout->bit_per_gpio[i] < 1 || layout->bit_per_gpio[i] > 8)
> return -EINVAL;
>
> - /* Check that on valiue fits it's placeholder */
> + /* Check that on value fits its placeholder */
> if (GENMASK(31, layout->bit_per_gpio[i]) & layout->on[i])
> return -EINVAL;
>
> - /* Check that off valiue fits it's placeholder */
> + /* Check that off value fits its placeholder */
> if (GENMASK(31, layout->bit_per_gpio[i]) & layout->off[i])
> return -EINVAL;
>
> --
> 2.24.1
>

The subject should be 'gpio: <driver name: ...' and this looks like a
new version of the series, so please mark it as such and describe the
differences between versions.

Please refer to Documentation/process/development-process.rst on how
to submit patches.

Bartosz