2021-02-24 18:58:14

by Bartosz Golaszewski

[permalink] [raw]
Subject: [PATCH] selftests: gpio: update .gitignore

From: Bartosz Golaszewski <[email protected]>

The executable that we build for GPIO selftests was renamed to
gpio-mockup-cdev. Let's update .gitignore so that we don't show it
as an untracked file.

Fixes: 8bc395a6a2e2 ("selftests: gpio: rework and simplify test implementation")
Signed-off-by: Bartosz Golaszewski <[email protected]>
---
tools/testing/selftests/gpio/.gitignore | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/gpio/.gitignore b/tools/testing/selftests/gpio/.gitignore
index 4c69408f3e84..a4969f7ee020 100644
--- a/tools/testing/selftests/gpio/.gitignore
+++ b/tools/testing/selftests/gpio/.gitignore
@@ -1,2 +1,2 @@
# SPDX-License-Identifier: GPL-2.0-only
-gpio-mockup-chardev
+gpio-mockup-cdev
--
2.29.1


2021-02-24 19:34:08

by Kent Gibson

[permalink] [raw]
Subject: Re: [PATCH] selftests: gpio: update .gitignore

On Wed, Feb 24, 2021 at 07:53:16PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <[email protected]>
>
> The executable that we build for GPIO selftests was renamed to
> gpio-mockup-cdev. Let's update .gitignore so that we don't show it
> as an untracked file.
>
> Fixes: 8bc395a6a2e2 ("selftests: gpio: rework and simplify test implementation")
> Signed-off-by: Bartosz Golaszewski <[email protected]>
> ---
> tools/testing/selftests/gpio/.gitignore | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/gpio/.gitignore b/tools/testing/selftests/gpio/.gitignore
> index 4c69408f3e84..a4969f7ee020 100644
> --- a/tools/testing/selftests/gpio/.gitignore
> +++ b/tools/testing/selftests/gpio/.gitignore
> @@ -1,2 +1,2 @@
> # SPDX-License-Identifier: GPL-2.0-only
> -gpio-mockup-chardev
> +gpio-mockup-cdev
> --

Thanks for picking this one up - I missed it as I don't build the
selftests in the same environment that I edit them in, and overlooked
that there was a .gitignore in play.

Reviewed-by: Kent Gibson <[email protected]>

Cheers,
Kent.

2021-03-04 06:34:45

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH] selftests: gpio: update .gitignore

On 3/2/21 7:44 AM, Linus Walleij wrote:
> On Wed, Feb 24, 2021 at 7:53 PM Bartosz Golaszewski <[email protected]> wrote:
>
>> From: Bartosz Golaszewski <[email protected]>
>>
>> The executable that we build for GPIO selftests was renamed to
>> gpio-mockup-cdev. Let's update .gitignore so that we don't show it
>> as an untracked file.
>>
>> Fixes: 8bc395a6a2e2 ("selftests: gpio: rework and simplify test implementation")
>> Signed-off-by: Bartosz Golaszewski <[email protected]>
>
> Reviewed-by: Linus Walleij <[email protected]>
>
> Yours,
> Linus Walleij
>


Thank you. I will queue this up.

thanks,
-- Shuah

2021-03-04 06:34:51

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH] selftests: gpio: update .gitignore

On 3/2/21 9:07 AM, Bartosz Golaszewski wrote:
> On Tue, Mar 2, 2021 at 4:27 PM Shuah Khan <[email protected]> wrote:
>>
>> On 3/2/21 7:44 AM, Linus Walleij wrote:
>>> On Wed, Feb 24, 2021 at 7:53 PM Bartosz Golaszewski <[email protected]> wrote:
>>>
>>>> From: Bartosz Golaszewski <[email protected]>
>>>>
>>>> The executable that we build for GPIO selftests was renamed to
>>>> gpio-mockup-cdev. Let's update .gitignore so that we don't show it
>>>> as an untracked file.
>>>>
>>>> Fixes: 8bc395a6a2e2 ("selftests: gpio: rework and simplify test implementation")
>>>> Signed-off-by: Bartosz Golaszewski <[email protected]>
>>>
>>> Reviewed-by: Linus Walleij <[email protected]>
>>>
>>> Yours,
>>> Linus Walleij
>>>
>>
>>
>> Thank you. I will queue this up.
>>
>> thanks,
>> -- Shuah
>
> Hi Shuah,
>
> Please let me queue this through the GPIO tree as I have some more
> development coming up this cycle that will require this. This will be
> a new driver + selftests so it will all have to go through the GPIO
> tree anyway.
>
> Bart
>

Perfect.

Acked-by: Shuah Khan <[email protected]>

thanks,
-- Shuah

2021-03-04 06:34:56

by Bartosz Golaszewski

[permalink] [raw]
Subject: Re: [PATCH] selftests: gpio: update .gitignore

On Tue, Mar 2, 2021 at 4:27 PM Shuah Khan <[email protected]> wrote:
>
> On 3/2/21 7:44 AM, Linus Walleij wrote:
> > On Wed, Feb 24, 2021 at 7:53 PM Bartosz Golaszewski <[email protected]> wrote:
> >
> >> From: Bartosz Golaszewski <[email protected]>
> >>
> >> The executable that we build for GPIO selftests was renamed to
> >> gpio-mockup-cdev. Let's update .gitignore so that we don't show it
> >> as an untracked file.
> >>
> >> Fixes: 8bc395a6a2e2 ("selftests: gpio: rework and simplify test implementation")
> >> Signed-off-by: Bartosz Golaszewski <[email protected]>
> >
> > Reviewed-by: Linus Walleij <[email protected]>
> >
> > Yours,
> > Linus Walleij
> >
>
>
> Thank you. I will queue this up.
>
> thanks,
> -- Shuah

Hi Shuah,

Please let me queue this through the GPIO tree as I have some more
development coming up this cycle that will require this. This will be
a new driver + selftests so it will all have to go through the GPIO
tree anyway.

Bart

2021-03-04 06:35:32

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH] selftests: gpio: update .gitignore

On Wed, Feb 24, 2021 at 7:53 PM Bartosz Golaszewski <[email protected]> wrote:

> From: Bartosz Golaszewski <[email protected]>
>
> The executable that we build for GPIO selftests was renamed to
> gpio-mockup-cdev. Let's update .gitignore so that we don't show it
> as an untracked file.
>
> Fixes: 8bc395a6a2e2 ("selftests: gpio: rework and simplify test implementation")
> Signed-off-by: Bartosz Golaszewski <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij