2019-05-10 10:17:18

by Bartosz Golaszewski

[permalink] [raw]
Subject: Re: [PATCH] Documentation: gpio: remove duplicated lines

pt., 10 maj 2019 o 11:03 Luca Ceresoli <[email protected]> napisaƂ(a):
>
> The 'default (active high)' lines are repeated twice. Avoid people stare at
> their screens looking for differences.
>
> Signed-off-by: Luca Ceresoli <[email protected]>
> ---
> Documentation/driver-api/gpio/consumer.rst | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/driver-api/gpio/consumer.rst b/Documentation/driver-api/gpio/consumer.rst
> index 5e4d8aa68913..23d68c321c5c 100644
> --- a/Documentation/driver-api/gpio/consumer.rst
> +++ b/Documentation/driver-api/gpio/consumer.rst
> @@ -283,8 +283,6 @@ To summarize::
> gpiod_set_value(desc, 1); default (active high) high
> gpiod_set_value(desc, 0); active low high
> gpiod_set_value(desc, 1); active low low
> - gpiod_set_value(desc, 0); default (active high) low
> - gpiod_set_value(desc, 1); default (active high) high
> gpiod_set_value(desc, 0); open drain low
> gpiod_set_value(desc, 1); open drain high impedance
> gpiod_set_value(desc, 0); open source high impedance
> --
> 2.21.0
>

Reviewed-by: Bartosz Golaszewski <[email protected]>