2020-03-03 21:45:49

by J. Neuschäfer

[permalink] [raw]
Subject: [PATCH] gpio: uapi: Improve phrasing around arrays representing empty strings

Character arrays can be considered empty strings (if they are
immediately terminated), but they cannot be NULL.

Signed-off-by: Jonathan Neuschäfer <[email protected]>
---
include/uapi/linux/gpio.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/uapi/linux/gpio.h b/include/uapi/linux/gpio.h
index 799cf823d493..cd88599ea3ea 100644
--- a/include/uapi/linux/gpio.h
+++ b/include/uapi/linux/gpio.h
@@ -18,7 +18,7 @@
* struct gpiochip_info - Information about a certain GPIO chip
* @name: the Linux kernel name of this GPIO chip
* @label: a functional name for this GPIO chip, such as a product
- * number, may be NULL
+ * number, may be empty
* @lines: number of GPIO lines on this chip
*/
struct gpiochip_info {
@@ -44,10 +44,10 @@ struct gpiochip_info {
* @flags: various flags for this line
* @name: the name of this GPIO line, such as the output pin of the line on the
* chip, a rail or a pin header name on a board, as specified by the gpio
- * chip, may be NULL
+ * chip, may be empty
* @consumer: a functional name for the consumer of this GPIO line as set by
- * whatever is using it, will be NULL if there is no current user but may
- * also be NULL if the consumer doesn't set this up
+ * whatever is using it, will be empty if there is no current user but may
+ * also be empty if the consumer doesn't set this up
*/
struct gpioline_info {
__u32 line_offset;
--
2.20.1


2020-03-04 14:12:20

by Bartosz Golaszewski

[permalink] [raw]
Subject: Re: [PATCH] gpio: uapi: Improve phrasing around arrays representing empty strings

wt., 3 mar 2020 o 21:06 Jonathan Neuschäfer <[email protected]> napisał(a):
>
> Character arrays can be considered empty strings (if they are
> immediately terminated), but they cannot be NULL.
>
> Signed-off-by: Jonathan Neuschäfer <[email protected]>

Makes sense, patch applied!

Bart