2021-03-03 13:55:42

by Andy Shevchenko

[permalink] [raw]
Subject: [PATCH v1 1/2] lib/cmdline: Export next_arg() for being used in modules

At least one module will benefit from using next_arg() helper.
Let's export it for that module and others if they consider it
helpful.

Signed-off-by: Andy Shevchenko <[email protected]>
---
lib/cmdline.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/lib/cmdline.c b/lib/cmdline.c
index 5d474c626e24..5546bf588780 100644
--- a/lib/cmdline.c
+++ b/lib/cmdline.c
@@ -272,3 +272,4 @@ char *next_arg(char *args, char **param, char **val)
/* Chew up trailing spaces. */
return skip_spaces(args);
}
+EXPORT_SYMBOL(next_arg);
--
2.30.1


2021-03-04 06:35:47

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH v1 1/2] lib/cmdline: Export next_arg() for being used in modules

On Mon, Mar 1, 2021 at 6:00 PM Andy Shevchenko
<[email protected]> wrote:

> At least one module will benefit from using next_arg() helper.
> Let's export it for that module and others if they consider it
> helpful.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2021-03-04 15:45:04

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH v1 1/2] lib/cmdline: Export next_arg() for being used in modules

On Mon, Mar 1, 2021 at 6:00 PM Andy Shevchenko
<[email protected]> wrote:
> At least one module will benefit from using next_arg() helper.
> Let's export it for that module and others if they consider it
> helpful.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2021-03-04 16:35:39

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v1 1/2] lib/cmdline: Export next_arg() for being used in modules

On Thu, Mar 04, 2021 at 09:53:28AM +0100, Geert Uytterhoeven wrote:
> On Mon, Mar 1, 2021 at 6:00 PM Andy Shevchenko
> <[email protected]> wrote:
> > At least one module will benefit from using next_arg() helper.
> > Let's export it for that module and others if they consider it
> > helpful.
> >
> > Signed-off-by: Andy Shevchenko <[email protected]>
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>

Thanks Geert and Linus!

Bart, do you want me to add it to my usual PR or you want to take it yourself
(I have no dependencies in my tree on this anyway)?

--
With Best Regards,
Andy Shevchenko


2021-03-08 15:43:09

by Bartosz Golaszewski

[permalink] [raw]
Subject: Re: [PATCH v1 1/2] lib/cmdline: Export next_arg() for being used in modules

On Thu, Mar 4, 2021 at 12:01 PM Andy Shevchenko
<[email protected]> wrote:
>
> On Thu, Mar 04, 2021 at 09:53:28AM +0100, Geert Uytterhoeven wrote:
> > On Mon, Mar 1, 2021 at 6:00 PM Andy Shevchenko
> > <[email protected]> wrote:
> > > At least one module will benefit from using next_arg() helper.
> > > Let's export it for that module and others if they consider it
> > > helpful.
> > >
> > > Signed-off-by: Andy Shevchenko <[email protected]>
> >
> > Reviewed-by: Geert Uytterhoeven <[email protected]>
>
> Thanks Geert and Linus!
>
> Bart, do you want me to add it to my usual PR or you want to take it yourself
> (I have no dependencies in my tree on this anyway)?
>
> --
> With Best Regards,
> Andy Shevchenko
>
>

Please send it with your PR.

Bart

2021-03-08 16:39:04

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v1 1/2] lib/cmdline: Export next_arg() for being used in modules

On Mon, Mar 08, 2021 at 04:38:42PM +0100, Bartosz Golaszewski wrote:
> On Thu, Mar 4, 2021 at 12:01 PM Andy Shevchenko
> <[email protected]> wrote:
> > On Thu, Mar 04, 2021 at 09:53:28AM +0100, Geert Uytterhoeven wrote:
> > > On Mon, Mar 1, 2021 at 6:00 PM Andy Shevchenko
> > > <[email protected]> wrote:
> > > > At least one module will benefit from using next_arg() helper.
> > > > Let's export it for that module and others if they consider it
> > > > helpful.
> > > >
> > > > Signed-off-by: Andy Shevchenko <[email protected]>
> > >
> > > Reviewed-by: Geert Uytterhoeven <[email protected]>
> >
> > Thanks Geert and Linus!
> >
> > Bart, do you want me to add it to my usual PR or you want to take it yourself
> > (I have no dependencies in my tree on this anyway)?
>
> Please send it with your PR.

Will do, thanks!

--
With Best Regards,
Andy Shevchenko