2021-02-05 10:30:31

by Bartosz Golaszewski

[permalink] [raw]
Subject: Re: [PATCH V5 0/5] gpio-xilinx: Update on xilinx gpio driver

On Fri, Jan 29, 2021 at 3:27 PM Srinivas Neeli
<[email protected]> wrote:
>
> This patch series does the following:
> -Simplify with dev_err_probe().
> -Reduce spinlock array to array.
> -Add interrupt support
> -Add support for suspend and resume
> -Add check for gpio-width
> ---
> Changes in V5:
> -Removed IRQ_DOMAIN_HIERARCHY from Kconfig and of_gpio.h
> from includes.
> -Added check for #gpio-cells.
> Changes in V4:
> -Created new patch to simplify code with dev_err_probe().
> -Updated minor review comments.
> -Created new patch to check gpio-width.
> Changes in V3:
> -Created separate patch to arrange headers in sorting order.
> -Updated dt-bindings.
> -Created separate patch for Clock changes and runtime resume.
> and suspend.
> -Created separate patch for spinlock changes.
> -Created separate patch for remove support.
> -Fixed coverity errors.
> -Updated minor review comments.
>
> Changes in V2:
> -Added check for return value of platform_get_irq() API.
> -Updated code to support rising edge and falling edge.
> -Added xgpio_xlate() API to support switch.
> -Added MAINTAINERS fragment.
>
> Tested Below scenarios:
> -Tested Loop Back.(channel 1.0 connected to channel 2.0)
> -Tested External switch(Used DIP switch)
> -Tested Cascade scenario(Here gpio controller acting as
> an interrupt controller).
> ---
>
> Srinivas Neeli (5):
> gpio: gpio-xilinx: Simplify with dev_err_probe()
> gpio: gpio-xilinx: Reduce spinlock array to array
> gpio: gpio-xilinx: Add interrupt support
> gpio: gpio-xilinx: Add support for suspend and resume
> gpio: gpio-xilinx: Add check if width exceeds 32
>
> drivers/gpio/Kconfig | 2 +
> drivers/gpio/gpio-xilinx.c | 369 ++++++++++++++++++++++++++++++++++++++++++---
> 2 files changed, 349 insertions(+), 22 deletions(-)
>
> --
> 2.7.4
>

Series applied, thanks!

Bartosz