2023-03-26 20:45:46

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 3/4] dt-bindings: display: elida,kd35t133: document port and rotation

Panels are supposed to have one port (defined in panel-common.yaml
binding) and can have also rotation:

rk3326-odroid-go2.dtb: panel@0: 'port', 'rotation' do not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/display/panel/elida,kd35t133.yaml | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml b/Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml
index 7adb83e2e8d9..265ab6d30572 100644
--- a/Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml
+++ b/Documentation/devicetree/bindings/display/panel/elida,kd35t133.yaml
@@ -17,7 +17,9 @@ properties:
const: elida,kd35t133
reg: true
backlight: true
+ port: true
reset-gpios: true
+ rotation: true
iovcc-supply:
description: regulator that supplies the iovcc voltage
vdd-supply:
@@ -27,6 +29,7 @@ required:
- compatible
- reg
- backlight
+ - port
- iovcc-supply
- vdd-supply

@@ -43,6 +46,12 @@ examples:
backlight = <&backlight>;
iovcc-supply = <&vcc_1v8>;
vdd-supply = <&vcc3v3_lcd>;
+
+ port {
+ mipi_in_panel: endpoint {
+ remote-endpoint = <&mipi_out_panel>;
+ };
+ };
};
};

--
2.34.1


2023-03-27 07:43:32

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH 3/4] dt-bindings: display: elida,kd35t133: document port and rotation

On 26/03/2023 22:42, Krzysztof Kozlowski wrote:
> Panels are supposed to have one port (defined in panel-common.yaml
> binding) and can have also rotation:
>
> rk3326-odroid-go2.dtb: panel@0: 'port', 'rotation' do not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/display/panel/elida,kd35t133.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)

<snip>

Reviewed-by: Neil Armstrong <[email protected]>

2023-03-28 18:34:04

by Jagan Teki

[permalink] [raw]
Subject: Re: [PATCH 3/4] dt-bindings: display: elida,kd35t133: document port and rotation

On Mon, Mar 27, 2023 at 2:12 AM Krzysztof Kozlowski
<[email protected]> wrote:
>
> Panels are supposed to have one port (defined in panel-common.yaml
> binding) and can have also rotation:
>
> rk3326-odroid-go2.dtb: panel@0: 'port', 'rotation' do not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---

Reviewed-by: Jagan Teki <[email protected]>