2020-11-04 10:58:36

by Prabhakar Mahadev Lad

[permalink] [raw]
Subject: [PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b

Add audio_clk_b configured as 0 Hz, this will be overridden by the
boards providing the audio clock.

Fixes: 8183a7938cfec ("arm64: dts: renesas: r8a774e1: Add audio support")
Reported-by: Nobuhiro Iwamatsu <[email protected]>
Signed-off-by: Lad Prabhakar <[email protected]>
---
Hi Geert,

I have rebased this patch on renesas-arm-dt-for-v5.10 branch.

Cheers,
Prabhakar
---
arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
index 9cbf963aa068..c29643442e91 100644
--- a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi
@@ -28,6 +28,12 @@
clock-frequency = <0>;
};

+ audio_clk_b: audio_clk_b {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <0>;
+ };
+
audio_clk_c: audio_clk_c {
compatible = "fixed-clock";
#clock-cells = <0>;
--
2.17.1


2020-11-09 10:04:42

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b

On Wed, Nov 4, 2020 at 11:55 AM Lad Prabhakar
<[email protected]> wrote:
> Add audio_clk_b configured as 0 Hz, this will be overridden by the
> boards providing the audio clock.
>
> Fixes: 8183a7938cfec ("arm64: dts: renesas: r8a774e1: Add audio support")
> Reported-by: Nobuhiro Iwamatsu <[email protected]>
> Signed-off-by: Lad Prabhakar <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>
i.e. will queue in renesas-devel for v5.11.

> I have rebased this patch on renesas-arm-dt-for-v5.10 branch.

Not renesas-arm-dt-for-v5.11?

Anyway, seems to apply cleanly.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2020-11-09 10:07:57

by Prabhakar Mahadev Lad

[permalink] [raw]
Subject: RE: [PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b

Hi Geert,

Thank you for the review.

> -----Original Message-----
> From: Geert Uytterhoeven <[email protected]>
> Sent: 09 November 2020 10:02
> To: Prabhakar Mahadev Lad <[email protected]>
> Cc: Magnus Damm <[email protected]>; Rob Herring <[email protected]>; Linux-Renesas <linux-
> [email protected]>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <[email protected]>; Linux Kernel Mailing List <[email protected]>; Biju Das
> <[email protected]>; Prabhakar <[email protected]>
> Subject: Re: [PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b
>
> On Wed, Nov 4, 2020 at 11:55 AM Lad Prabhakar
> <[email protected]> wrote:
> > Add audio_clk_b configured as 0 Hz, this will be overridden by the
> > boards providing the audio clock.
> >
> > Fixes: 8183a7938cfec ("arm64: dts: renesas: r8a774e1: Add audio support")
> > Reported-by: Nobuhiro Iwamatsu <[email protected]>
> > Signed-off-by: Lad Prabhakar <[email protected]>
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>
> i.e. will queue in renesas-devel for v5.11.
>
> > I have rebased this patch on renesas-arm-dt-for-v5.10 branch.
>
> Not renesas-arm-dt-for-v5.11?
>
Since this was a fixup, I was hoping this will go into v5.10 as a result I rebased it on renesas-arm-dt-for-v5.10 branch.

Cheers,
Prabhakar

> Anyway, seems to apply cleanly.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds

2020-11-09 10:12:16

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b

Hi Prabhakar,

On Mon, Nov 9, 2020 at 11:05 AM Prabhakar Mahadev Lad
<[email protected]> wrote:
> > -----Original Message-----
> > From: Geert Uytterhoeven <[email protected]>
> > Sent: 09 November 2020 10:02
> > To: Prabhakar Mahadev Lad <[email protected]>
> > Cc: Magnus Damm <[email protected]>; Rob Herring <[email protected]>; Linux-Renesas <linux-
> > [email protected]>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> > <[email protected]>; Linux Kernel Mailing List <[email protected]>; Biju Das
> > <[email protected]>; Prabhakar <[email protected]>
> > Subject: Re: [PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b
> >
> > On Wed, Nov 4, 2020 at 11:55 AM Lad Prabhakar
> > <[email protected]> wrote:
> > > Add audio_clk_b configured as 0 Hz, this will be overridden by the
> > > boards providing the audio clock.
> > >
> > > Fixes: 8183a7938cfec ("arm64: dts: renesas: r8a774e1: Add audio support")
> > > Reported-by: Nobuhiro Iwamatsu <[email protected]>
> > > Signed-off-by: Lad Prabhakar <[email protected]>
> >
> > Reviewed-by: Geert Uytterhoeven <[email protected]>
> > i.e. will queue in renesas-devel for v5.11.
> >
> > > I have rebased this patch on renesas-arm-dt-for-v5.10 branch.
> >
> > Not renesas-arm-dt-for-v5.11?
> >
> Since this was a fixup, I was hoping this will go into v5.10 as a result I rebased it on renesas-arm-dt-for-v5.10 branch.

OK. Will queue in renesas-fixes-for-v5.10 instead.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2020-11-09 10:16:23

by Prabhakar Mahadev Lad

[permalink] [raw]
Subject: RE: [PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b

Hi Geert,

> -----Original Message-----
> From: Geert Uytterhoeven <[email protected]>
> Sent: 09 November 2020 10:10
> To: Prabhakar Mahadev Lad <[email protected]>
> Cc: Magnus Damm <[email protected]>; Rob Herring <[email protected]>; Linux-Renesas <linux-
> [email protected]>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <[email protected]>; Linux Kernel Mailing List <[email protected]>; Biju Das
> <[email protected]>; Prabhakar <[email protected]>
> Subject: Re: [PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b
>
> Hi Prabhakar,
>
> On Mon, Nov 9, 2020 at 11:05 AM Prabhakar Mahadev Lad
> <[email protected]> wrote:
> > > -----Original Message-----
> > > From: Geert Uytterhoeven <[email protected]>
> > > Sent: 09 November 2020 10:02
> > > To: Prabhakar Mahadev Lad <[email protected]>
> > > Cc: Magnus Damm <[email protected]>; Rob Herring <[email protected]>; Linux-Renesas <linux-
> > > [email protected]>; open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> > > <[email protected]>; Linux Kernel Mailing List <[email protected]>; Biju Das
> > > <[email protected]>; Prabhakar <[email protected]>
> > > Subject: Re: [PATCH] arm64: dts: renesas: r8a774e1: Add missing audio_clk_b
> > >
> > > On Wed, Nov 4, 2020 at 11:55 AM Lad Prabhakar
> > > <[email protected]> wrote:
> > > > Add audio_clk_b configured as 0 Hz, this will be overridden by the
> > > > boards providing the audio clock.
> > > >
> > > > Fixes: 8183a7938cfec ("arm64: dts: renesas: r8a774e1: Add audio support")
> > > > Reported-by: Nobuhiro Iwamatsu <[email protected]>
> > > > Signed-off-by: Lad Prabhakar <[email protected]>
> > >
> > > Reviewed-by: Geert Uytterhoeven <[email protected]>
> > > i.e. will queue in renesas-devel for v5.11.
> > >
> > > > I have rebased this patch on renesas-arm-dt-for-v5.10 branch.
> > >
> > > Not renesas-arm-dt-for-v5.11?
> > >
> > Since this was a fixup, I was hoping this will go into v5.10 as a result I rebased it on renesas-
> arm-dt-for-v5.10 branch.
>
> OK. Will queue in renesas-fixes-for-v5.10 instead.
>
Thank you.

Cheers,
Prabhakar

> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds