Hi Claudiu,
On Thu, Feb 1, 2024 at 2:30 AM Claudiu <[email protected]> wrote:
> From: Claudiu Beznea <[email protected]>
>
> The rzg2l_wdt watchdog driver cannot work w/o CONFIG_PM=y (e.g. the
> clocks are enabled though pm_runtime_* specific APIs). To avoid building
> a driver that don't work select CONFIG_PM.
>
> Suggested-by: Guenter Roeck <[email protected]>
> Signed-off-by: Claudiu Beznea <[email protected]>
Thanks for your patch!
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -912,6 +912,7 @@ config RENESAS_RZG2LWDT
> tristate "Renesas RZ/G2L WDT Watchdog"
> depends on ARCH_RENESAS || COMPILE_TEST
> select WATCHDOG_CORE
> + select PM
depends on PM
The availability of PM is architecture/platform-specific, hence it
must not be selected by individual drivers.
> help
> This driver adds watchdog support for the integrated watchdogs in the
> Renesas RZ/G2L SoCs. These watchdogs can be used to reset a system.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On 2/1/24 00:52, Geert Uytterhoeven wrote:
> Hi Claudiu,
>
> On Thu, Feb 1, 2024 at 2:30 AM Claudiu <[email protected]> wrote:
>> From: Claudiu Beznea <[email protected]>
>>
>> The rzg2l_wdt watchdog driver cannot work w/o CONFIG_PM=y (e.g. the
>> clocks are enabled though pm_runtime_* specific APIs). To avoid building
>> a driver that don't work select CONFIG_PM.
>>
>> Suggested-by: Guenter Roeck <[email protected]>
>> Signed-off-by: Claudiu Beznea <[email protected]>
>
> Thanks for your patch!
>
>> --- a/drivers/watchdog/Kconfig
>> +++ b/drivers/watchdog/Kconfig
>> @@ -912,6 +912,7 @@ config RENESAS_RZG2LWDT
>> tristate "Renesas RZ/G2L WDT Watchdog"
>> depends on ARCH_RENESAS || COMPILE_TEST
>> select WATCHDOG_CORE
>> + select PM
>
> depends on PM
>
Yes, I did not want to suggest that the driver should _select_ PM.
Sorry that I wasn't more specific.
Guenter
> The availability of PM is architecture/platform-specific, hence it
> must not be selected by individual drivers.
>
>> help
>> This driver adds watchdog support for the integrated watchdogs in the
>> Renesas RZ/G2L SoCs. These watchdogs can be used to reset a system.
>
> Gr{oetje,eeting}s,
>
> Geert
>
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>